-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds action that checks if an audit is required for a given PR #776
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# Audit Requirement Checker | ||
# - checks if an audit is required for a given PR | ||
# - an audit is required if any .sol file in path 'src/' has been modified or added | ||
# - if audit is required, the action will assign the label "AuditRequired", otherwise it will assign label "AuditNotRequired" | ||
# - it will also make sure that at the end, exactly one of these two labels is indeed assigned | ||
|
||
name: Audit Requirement Check | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
check-audit-required: | ||
if: ${{ github.event.pull_request.draft == false }} # will only run once the PR is in "Ready for Review" state | ||
runs-on: ubuntu-latest | ||
permissions: | ||
pull-requests: write | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 ##### Fetch all history for all branches | ||
|
||
- name: Remove existing 'AuditRequired' and 'AuditNotRequired' labels | ||
uses: actions-ecosystem/action-remove-labels@v1 | ||
with: | ||
github_token: ${{ secrets.GIT_ACTIONS_BOT_PAT_CLASSIC }} | ||
labels: | | ||
AuditRequired | ||
AuditNotRequired | ||
number: ${{ github.event.pull_request.number }} | ||
|
||
- name: Check Git Diff for protected contracts | ||
id: check_eligibility | ||
run: | | ||
|
||
##### get all files modified by this PR | ||
FILES=$(git diff --name-only origin/main HEAD) | ||
|
||
##### make sure that there are modified files | ||
if [[ -z $FILES ]]; then | ||
echo -e "\033[31mNo files found. This should not happen. Please check the code of the Github action. Aborting now.\033[0m" | ||
echo "CONTINUE=false" >> $GITHUB_ENV | ||
fi | ||
|
||
##### Initialize empty variables | ||
PROTECTED_CONTRACTS="" | ||
|
||
##### go through all modified file names/paths and identify contracts with path 'src/*' | ||
while IFS= read -r FILE; do | ||
if echo "$FILE" | grep -E '^src/.*\.sol$'; then | ||
##### contract found | ||
PROTECTED_CONTRACTS="${PROTECTED_CONTRACTS}${FILE}"$'\n' | ||
fi | ||
done <<< "$FILES" | ||
|
||
##### if none found, exit here as there is nothing to do | ||
if [[ -z "$PROTECTED_CONTRACTS" ]]; then | ||
echo -e "\033[32mNo protected contracts found in Git Diff.\033[0m" | ||
echo -e "\033[32mAssigning label 'AuditNotRequired' to this PR.\033[0m" | ||
echo "AUDIT_REQUIRED=false" >> $GITHUB_ENV | ||
exit 0 | ||
else | ||
echo -e "\033[31mProtected contracts found in Git Diff.\033[0m" | ||
echo -e "\033[31mAssigning label 'AuditRequired' to this PR.\033[0m" | ||
echo "AUDIT_REQUIRED=true" >> $GITHUB_ENV | ||
fi | ||
|
||
echo "PROTECTED_CONTRACTS: $PROTECTED_CONTRACTS" | ||
|
||
##### Write filenames to temporary files (using variables here was causing issues due to the file names) | ||
echo -e "$PROTECTED_CONTRACTS" > protected_contracts.txt | ||
|
||
- name: Assign correct label based on check outcome | ||
uses: actions-ecosystem/action-add-labels@v1 | ||
id: assign_label | ||
with: | ||
github_token: ${{ secrets.GIT_ACTIONS_BOT_PAT_CLASSIC }} # we use the token of the git action user so the label protection check will pass | ||
labels: ${{ env.AUDIT_REQUIRED == 'true' && 'AuditRequired' || 'AuditNotRequired' }} # if the action made it until here and CONTINUE was true then all checks passed. It CONTINUE was false then no audit is required | ||
number: ${{ github.event.pull_request.number }} | ||
|
||
- name: Verify label assignments (make sure exactly one of the two labels is assigned) | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GIT_ACTIONS_BOT_PAT_CLASSIC }} | ||
run: | | ||
|
||
echo "Fetching currently assigned labels..." | ||
assigned_labels=$(gh pr view ${{ github.event.pull_request.number }} --json labels --jq '.labels | map(.name) | .[]') | ||
|
||
echo "Assigned labels: $assigned_labels" | ||
|
||
audit_required_assigned=0 | ||
audit_not_required_assigned=0 | ||
|
||
##### go through all assigned labels and count how many protected labels are found | ||
for label in $assigned_labels; do | ||
if [ "$label" = "AuditRequired" ]; then | ||
audit_required_assigned=$((audit_required_assigned + 1)) | ||
elif [ "$label" = "AuditNotRequired" ]; then | ||
audit_not_required_assigned=$((audit_not_required_assigned + 1)) | ||
fi | ||
done | ||
|
||
total_labels_assigned=$((audit_required_assigned + audit_not_required_assigned)) | ||
echo "Total labels assigned: $total_labels_assigned" | ||
|
||
##### make sure that exactly (only) one protected label is assigned | ||
if [ "$total_labels_assigned" -ne 1 ]; then | ||
echo -e "\033[31mError: Exactly one of the two labels should be assigned but found $total_labels_assigned assigned labels.\033[0m" | ||
exit 1 | ||
else | ||
echo -e "\033[32mVerified that exactly one label is assigned.\033[0m" | ||
echo -e "\033[32mAll good :)\033[0m" | ||
fi | ||
|
||
echo -e "\033[31mGit Action completed successfully\033[0m" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote variables to prevent globbing and word splitting.
The shell script contains unquoted variables, which can lead to issues with globbing and word splitting. Address the shellcheck warnings by quoting variables.
Apply this diff to quote the variables:
Committable suggestion
Tools
actionlint