validate constructor args

src/Facets/ChainflipFacet.sol

@@ -9,7 +9,7 @@ import { SwapperV2 } from "../Helpers/SwapperV2.sol";
 import { Validatable } from "../Helpers/Validatable.sol";
 import { IChainflipVault } from "../Interfaces/IChainflip.sol";
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
-import { InformationMismatch } from "../Errors/GenericErrors.sol";
+import { InformationMismatch, InvalidConfig } from "../Errors/GenericErrors.sol";
 
 /// @title Chainflip Facet
 /// @author LI.FI (https://li.fi)
@@ -62,6 +62,9 @@ contract ChainflipFacet is ILiFi, ReentrancyGuard, SwapperV2, Validatable {
     /// @notice Constructor for the contract.
     /// @param _chainflipVault Address of the Chainflip vault contract
     constructor(IChainflipVault _chainflipVault) {
+        if (address(_chainflipVault) == address(0)) {
+            revert InvalidConfig();
+        }
         chainflipVault = _chainflipVault;
     }
 

src/Periphery/ReceiverChainflip.sol

@@ -8,6 +8,7 @@ import { IExecutor } from "../Interfaces/IExecutor.sol";
 import { WithdrawablePeriphery } from "../Helpers/WithdrawablePeriphery.sol";
 import { SafeTransferLib } from "solady/utils/SafeTransferLib.sol";
 import { console2 } from "forge-std/console2.sol";
+import { InvalidConfig } from "../Errors/GenericErrors.sol";
 
 /// @title ReceiverChainflip
 /// @author LI.FI (https://li.fi)
@@ -49,6 +50,13 @@ contract ReceiverChainflip is ILiFi, WithdrawablePeriphery {
         address _executor,
         address _chainflipVault
     ) WithdrawablePeriphery(_owner) {
+        if (
+            _owner == address(0) ||
+            _executor == address(0) ||
+            _chainflipVault == address(0)
+        ) {
+            revert InvalidConfig();
+        }
         executor = IExecutor(_executor);
         chainflipVault = _chainflipVault;
     }

test/solidity/Facets/ChainflipFacet.t.sol

@@ -6,7 +6,7 @@ import { ChainflipFacet } from "lifi/Facets/ChainflipFacet.sol";
 import { IChainflipVault } from "lifi/Interfaces/IChainflip.sol";
 import { LibAsset } from "lifi/Libraries/LibAsset.sol";
 import { LibSwap } from "lifi/Libraries/LibSwap.sol";
-import { InformationMismatch, CannotBridgeToSameNetwork } from "lifi/Errors/GenericErrors.sol";
+import { InformationMismatch, CannotBridgeToSameNetwork, InvalidConfig } from "lifi/Errors/GenericErrors.sol";
 
 // Stub ChainflipFacet Contract
 contract TestChainflipFacet is ChainflipFacet {
@@ -82,6 +82,11 @@ contract ChainflipFacetTest is TestBaseFacet {
         validChainflipData.dstToken = 7;
     }
 
+    function testRevert_WhenConstructedWithZeroAddress() public {
+        vm.expectRevert(InvalidConfig.selector);
+        new TestChainflipFacet(address(0));
+    }
+
     function initiateBridgeTxWithFacet(bool isNative) internal override {
         if (isNative) {
             chainflipFacet.startBridgeTokensViaChainflip{

test/solidity/Periphery/ReceiverChainflip.t.sol

@@ -2,7 +2,7 @@
 pragma solidity ^0.8.17;
 
 import { TestBase, ILiFi, LibSwap, console, ERC20, UniswapV2Router02 } from "../utils/TestBase.sol";
-import { ExternalCallFailed, UnAuthorized } from "src/Errors/GenericErrors.sol";
+import { ExternalCallFailed, UnAuthorized, InvalidConfig } from "src/Errors/GenericErrors.sol";
 import { ReceiverChainflip } from "lifi/Periphery/ReceiverChainflip.sol";
 import { LibAsset } from "lifi/Libraries/LibAsset.sol";
 import { stdJson } from "forge-std/Script.sol";
@@ -27,6 +27,20 @@ contract ReceiverChainflipTest is TestBase {
 
     event ExecutorSet(address indexed executor);
 
+    function testRevert_WhenConstructedWithZeroAddresses() public {
+        // Test zero owner address
+        vm.expectRevert(InvalidConfig.selector);
+        new ReceiverChainflip(address(0), address(executor), chainflipVault);
+
+        // Test zero executor address
+        vm.expectRevert(InvalidConfig.selector);
+        new ReceiverChainflip(address(this), address(0), chainflipVault);
+
+        // Test zero chainflip vault address
+        vm.expectRevert(InvalidConfig.selector);
+        new ReceiverChainflip(address(this), address(executor), address(0));
+    }
+
     function setUp() public {
         customBlockNumberForForking = 18277082;
         initTestBase();
@@ -49,6 +63,8 @@ contract ReceiverChainflipTest is TestBase {
         vm.label(address(erc20Proxy), "ERC20Proxy");
     }
 
+    // AI! add a test that makes sure we revert when constructing with zero address. Check each arg. Make sure to import InvalidConfig from GenericErrors
+
     function test_ContractIsSetUpCorrectly() public {
         receiver = new ReceiverChainflip(
             address(this),