Change handlebars to ember-handlebars so linguist scope tests pass #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Linguist will not merge the glimmer syntax because our handlebars scope name clashes with actual handlebars.
github-linguist/linguist#6578 (comment)
I've updated the scope names to
ember-handlebars
which should make it safe for linguist to merge.I've quickly tested this change in vscode and all seems to be highlighting correctly but would appreciate someone else testing before we merge this PR.
The next release of linguist is 12 December so getting this merged and released asap would be good.