Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change handlebars to ember-handlebars so linguist scope tests pass #48

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

evoactivity
Copy link
Contributor

GitHub Linguist will not merge the glimmer syntax because our handlebars scope name clashes with actual handlebars.

github-linguist/linguist#6578 (comment)

I've updated the scope names to ember-handlebars which should make it safe for linguist to merge.

I've quickly tested this change in vscode and all seems to be highlighting correctly but would appreciate someone else testing before we merge this PR.

The next release of linguist is 12 December so getting this merged and released asap would be good.

@lifeart
Copy link
Owner

lifeart commented Dec 7, 2023

Hi @evoactivity! Thank you for PR! Changes seems good.
Quick search on codebase gives me this dependency match:
image
Are we good that changing things here not break prettier scope?

@evoactivity
Copy link
Contributor Author

If I search in the prettier repo for that I only find the string in a test snapshot.

https://github.com/search?q=repo%3Aprettier%2Fprettier%20text.html.handlebars&type=code

I believe that's generated at build time and pulled in from https://github.com/ikatyang/linguist-languages

For what it's worth prettier seems to be functioning correctly in my test repo.

@lifeart lifeart merged commit 01e7c35 into lifeart:master Dec 7, 2023
@evoactivity evoactivity deleted the make-handlebars-ember-focused branch December 7, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants