Skip to content

Commit

Permalink
appimage: bump kf/krs/plasma versions to 5.69.0/20.04.0/5.18.4
Browse files Browse the repository at this point in the history
GIT_SILENT
  • Loading branch information
kossebau committed Apr 28, 2020
1 parent 1376f89 commit 522c033
Show file tree
Hide file tree
Showing 7 changed files with 109 additions and 36 deletions.
18 changes: 18 additions & 0 deletions appimage/breeze-noconstexpr.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/kstyle/breezehelper.h b/kstyle/breezehelper.h
index 3b6320dc..ab42981c 100644
--- a/kstyle/breezehelper.h
+++ b/kstyle/breezehelper.h
@@ -314,11 +314,11 @@ namespace Breeze
//@}

//* frame radius
- constexpr qreal frameRadius( const int penWidth = PenWidth::NoPen, const qreal bias = 0 ) const
+ qreal frameRadius( const int penWidth = PenWidth::NoPen, const qreal bias = 0 ) const
{ return qMax( Metrics::Frame_FrameRadius - (0.5 * penWidth) + bias, 0.0 ); }

//* frame radius with new pen width
- constexpr qreal frameRadiusForNewPenWidth( const qreal oldRadius, const int penWidth ) const
+ qreal frameRadiusForNewPenWidth( const qreal oldRadius, const int penWidth ) const
{ return qMax( oldRadius - (0.5 * penWidth), 0.0 ); }

//* return a QRectF with the appropriate size for a rectangle with a pen stroke
27 changes: 27 additions & 0 deletions appimage/breezeicons-compatcmake3.6.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7f649eb5..19661a2f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -39,6 +39,13 @@ function(generate_binary_resource target outfile)
set(RESOURCE_FILE ${RESOURCES_WORKING_DIR}/breeze-${target}.qrc)
set(BINARY_RESOURCE_FILE ${CMAKE_CURRENT_BINARY_DIR}/breeze-${target}.rcc)

+ # Use $<IF:$<BOOL:${MSVC}>,PATH,LD_LIBRARY_PATH> instead of ${pathVarName} once CMake 3.8 is minimum
+ if(MSVC)
+ set(pathVarName PATH)
+ else()
+ set(pathVarName LD_LIBRARY_PATH)
+ endif()
+
get_target_property(QT_RCC_EXECUTABLE Qt5::rcc LOCATION)

add_custom_target(breeze-${target}-mkdir
@@ -53,7 +60,7 @@ function(generate_binary_resource target outfile)
${RESOURCES_WORKING_DIR}/CMakeLists.txt
COMMAND ${QT_RCC_EXECUTABLE} --project -o ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc
COMMAND ${CMAKE_COMMAND} -E env
- $<IF:$<BOOL:${MSVC}>,PATH,LD_LIBRARY_PATH>=$<TARGET_FILE_DIR:Qt5::Core>
+ ${pathVarName}=$<TARGET_FILE_DIR:Qt5::Core>
$<TARGET_FILE:qrcAlias> -i ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc -o ${RESOURCE_FILE}

WORKING_DIRECTORY ${RESOURCES_WORKING_DIR}
22 changes: 11 additions & 11 deletions appimage/kdevelop-recipe-centos6.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ fi
if [ -z "$KDEV_PG_QT_VERSION" ]; then
KDEV_PG_QT_VERSION=v2.2.1
fi
# remove kxmlgui_fixdockvisibilitystatestoring.patch for >5.66.0
# remove ktexteditor_fixdragncopy.patch for >5.66.0
KF5_VERSION=v5.66.0
PLASMA_VERSION=v5.17.5
KDE_RELEASESERVICE_VERSION=v19.12.1
# remove breezeicons-compatcmake3.6.patch for >5.69.0
KF5_VERSION=v5.69.0
PLASMA_VERSION=v5.18.4
# remove konsole-nooptionalinclude.patch for >20.04.0 (check https://invent.kde.org/kde/konsole/-/merge_requests/85)
KDE_RELEASESERVICE_VERSION=v20.04.0
GRANTLEE_VERSION=v5.2.0
OKTETA_VERSION=v0.26.3

Expand Down Expand Up @@ -176,7 +176,7 @@ build_framework kconfigwidgets -DBUILD_DESIGNERPLUGIN=OFF
build_framework kiconthemes -DBUILD_DESIGNERPLUGIN=OFF
build_framework ktextwidgets -DBUILD_DESIGNERPLUGIN=OFF
build_framework kglobalaccel
(PATCH_FILE=$SCRIPT_DIR/kxmlgui_fixdockvisibilitystatestoring.patch build_framework kxmlgui -DBUILD_DESIGNERPLUGIN=OFF)
build_framework kxmlgui -DBUILD_DESIGNERPLUGIN=OFF
build_framework kbookmarks
build_framework solid
build_framework kio -DBUILD_DESIGNERPLUGIN=OFF
Expand All @@ -186,27 +186,27 @@ build_framework threadweaver
build_framework attica
build_framework knewstuff
build_framework syntax-highlighting
(PATCH_FILE=$SCRIPT_DIR/ktexteditor_fixdragncopy.patch build_framework ktexteditor)
build_framework ktexteditor
build_framework kpackage
build_framework kdeclarative
build_framework kcmutils
(PATCH_FILE=$SCRIPT_DIR/knotifications_no_phonon.patch build_framework knotifications)
build_framework knotifyconfig
(PATCH_FILE=$SCRIPT_DIR/knotifyconfig_no_phonon.patch build_framework knotifyconfig)
build_framework kdoctools
build_framework breeze-icons -DBINARY_ICONS_RESOURCE=1
(PATCH_FILE=$SCRIPT_DIR/breezeicons-compatcmake3.6.patch build_framework breeze-icons -DBINARY_ICONS_RESOURCE=1)
build_framework kpty
build_framework kinit
fi

# KDE Plasma
build_project libksysguard $PLASMA_VERSION
build_project kdecoration $PLASMA_VERSION # needed by breeze
build_project breeze $PLASMA_VERSION
(PATCH_FILE=$SCRIPT_DIR/breeze-noconstexpr.patch build_project breeze $PLASMA_VERSION)

# KDE Applications
build_project libkomparediff2 $KDE_RELEASESERVICE_VERSION
build_project kate $KDE_RELEASESERVICE_VERSION -DDISABLE_ALL_OPTIONAL_SUBDIRECTORIES=TRUE -DBUILD_addons=TRUE -DBUILD_snippets=TRUE -DBUILD_kate-ctags=TRUE
build_project konsole $KDE_RELEASESERVICE_VERSION
(PATCH_FILE=$SCRIPT_DIR/konsole-nooptionalinclude.patch build_project konsole $KDE_RELEASESERVICE_VERSION)
build_project okteta $OKTETA_VERSION -DBUILD_DESIGNERPLUGIN=OFF -DBUILD_OKTETAKASTENLIBS=OFF

# Extra
Expand Down
39 changes: 39 additions & 0 deletions appimage/knotifyconfig_no_phonon.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 155422d..59b6768 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -35,15 +35,16 @@ find_package(Canberra)
set_package_properties(Canberra PROPERTIES
PURPOSE "Needed to preview notification sounds"
TYPE OPTIONAL)
+set(Canberra_FOUND FALSE)
if (Canberra_FOUND)
add_definitions(-DHAVE_CANBERRA)
else()
# This is REQUIRED since you cannot tell CMake "either one of those two optional ones are required"
- find_package(Phonon4Qt5 4.6.60 NO_MODULE REQUIRED)
- set_package_properties(Phonon4Qt5 PROPERTIES
- DESCRIPTION "Qt-based audio library"
- PURPOSE "Needed to preview notification sounds when Canberra isn't available")
- add_definitions(-DHAVE_PHONON4QT5)
+# find_package(Phonon4Qt5 4.6.60 NO_MODULE REQUIRED)
+# set_package_properties(Phonon4Qt5 PROPERTIES
+# DESCRIPTION "Qt-based audio library"
+# PURPOSE "Needed to preview notification sounds when Canberra isn't available")
+# add_definitions(-DHAVE_PHONON4QT5)
endif()

# Includes
diff --git a/src/knotify-config.h.cmake b/src/knotify-config.h.cmake
index 1794afc..7917612 100644
--- a/src/knotify-config.h.cmake
+++ b/src/knotify-config.h.cmake
@@ -1,7 +1,7 @@
#ifndef KNOTIFY_CONFIG_H
#define KNOTIFY_CONFIG_H

-#cmakedefine01 HAVE_PHONON
+#cmakedefine HAVE_PHONON

#endif /* KNOTIFY_CONFIG_H */

14 changes: 14 additions & 0 deletions appimage/konsole-nooptionalinclude.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/src/Filter.h b/src/Filter.h
index 0dd98151..527e8540 100644
--- a/src/Filter.h
+++ b/src/Filter.h
@@ -34,9 +34,6 @@
// Konsole
#include "Character.h"

-// std
-#include <optional>
-
class QAction;

namespace Konsole {
13 changes: 0 additions & 13 deletions appimage/ktexteditor_fixdragncopy.patch

This file was deleted.

12 changes: 0 additions & 12 deletions appimage/kxmlgui_fixdockvisibilitystatestoring.patch

This file was deleted.

0 comments on commit 522c033

Please sign in to comment.