Merge pull request #48 from lidofinance/required-unique-key

Required unique key

Changelog.md

@@ -1,3 +1,6 @@
+## 28.11.2024
+1. Field "uniqueKey" is required for getting quorum.
+
 ## 16.10.2024
 1. Added dynamic yaml notification config
 

brief/databus/finding.dto.json

@@ -37,7 +37,7 @@
       "type": "string"
     }
   },
-  "required": ["severity", "alertId", "name", "description", "botName", "team"],
+  "required": ["severity", "alertId", "name", "description", "botName", "team", "uniqueKey"],
   "definitions": {
     "Severity": {
       "type": "string",

cmd/forwarder/main.go

@@ -81,6 +81,7 @@ func main() {
 		MaxAge:     10 * time.Minute,
 		Subjects:   env.CollectNatsSubjects(notificationConfig),
 		MaxMsgSize: maxMsgSize,
+		Retention:  jetstream.InterestPolicy,
 	})
 	if err != nil && !errors.Is(err, nats.ErrStreamNameAlreadyInUse) {
 		fmt.Printf("could not create %s stream error: %v\n", natsStreamName, err)

internal/pkg/consumer/consumer.go

@@ -1,10 +1,7 @@
 package consumer
 
 import (
-	"bytes"
 	"context"
-	"crypto/sha256"
-	"encoding/hex"
 	"encoding/json"
 	"fmt"
 	"log/slog"
@@ -208,7 +205,7 @@ func (c *Consumer) GetConsumeHandler(ctx context.Context) func(msg jetstream.Msg
 			return
 		}
 
-		key := findingToUniqueHash(finding)
+		key := finding.UniqueKey
 		countKey := fmt.Sprintf(countTemplate, c.name, key)
 		statusKey := fmt.Sprintf(statusTemplate, c.name, key)
 
@@ -405,26 +402,3 @@ func (c *Consumer) ackMessage(msg jetstream.Msg) {
 		c.log.Error(fmt.Sprintf(`Could not ack msg: %v`, ackErr))
 	}
 }
-
-func computeSHA256Hash(data []byte) string {
-	hash := sha256.Sum256(data)
-	return hex.EncodeToString(hash[:])
-}
-
-func findingToUniqueHash(f *databus.FindingDtoJson) string {
-	var buffer bytes.Buffer
-
-	if f.UniqueKey != nil {
-		buffer.WriteString(f.Team)
-		buffer.WriteString(f.BotName)
-		buffer.WriteString(*f.UniqueKey)
-	} else {
-		buffer.WriteString(f.Team)
-		buffer.WriteString(f.BotName)
-		buffer.WriteString(f.AlertId)
-		buffer.WriteString(f.Name)
-		buffer.WriteString(string(f.Severity))
-	}
-
-	return computeSHA256Hash(buffer.Bytes())
-}