chore: add slot finality checking #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the block returned by the node for the given block ID is finalized and, if not, use the fallback node. Fix some lint errors.
vgorkavenko
reviewed
Aug 16, 2024
Move the reading of the `workingMode` from the env config from specific methods to the service constructor.
1. Add checking of block finalization to some other methods of the Consensus Provider service. 2. Now the finalization check in the appropriate methods also checks that the method is not querying the head block. 3. Remove unused methods from the Consensus Provider service.
Reorganize conditions that are checked in the `useFallbackOnResolved` callback. Now the most frequent ones are checked first.
Remove the word "state" from the error logs in the `useFallbackOnResolved` callback where it is unnecessary.
vgorkavenko
reviewed
Aug 22, 2024
vgorkavenko
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the block returned by the node for the given block ID is finalized and, if not, use the fallback node.
Fix some lint errors.