Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge guide #485

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Bridge guide #485

merged 4 commits into from
Dec 9, 2024

Conversation

iamnp
Copy link
Contributor

@iamnp iamnp commented Dec 7, 2024

No description provided.

@iamnp iamnp requested a review from TheDZhon December 7, 2024 13:23
@iamnp iamnp requested a review from a team as a code owner December 7, 2024 13:23
TheDZhon
TheDZhon requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for updating the guide, I'd suggest to revise the meaning of the NEW→NEC update, bc:

  1. NEW acted as a workgroup with only 'recommendation' sentiment
  2. NEC has a formal assignment from the Lido DAO to recognize bridging endpoints

docs/token-guides/wsteth-bridging-guide.md Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon merged commit 197f6f8 into main Dec 9, 2024
1 check passed
@TheDZhon TheDZhon deleted the feat/bridge-guide branch December 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arwer13 arwer13 arwer13 approved these changes

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamnp @TheDZhon @arwer13