Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better docs for Lido #248

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Better docs for Lido #248

merged 4 commits into from
Aug 18, 2023

Conversation

folkyatina
Copy link
Member

Related to #217

  • line width 80 to better review in GH PR
  • semantic structure for ABI reference
  • removed Parameters and Returns subheaders (too noisy and repetitive)
  • improve wording somewhere

@folkyatina folkyatina requested a review from a team as a code owner August 15, 2023 10:20
@folkyatina folkyatina requested review from TheDZhon and arwer13 August 15, 2023 10:20
TheDZhon
TheDZhon approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

docs/contracts/lido.md Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit ef4b98e into main Aug 18, 2023
@TheDZhon TheDZhon deleted the lido-v2/lido-polish branch August 18, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

@arwer13 arwer13 Awaiting requested review from arwer13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkyatina @TheDZhon