Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wsteth deposits #90

Closed
wants to merge 1 commit into from
Closed

Remove wsteth deposits #90

wants to merge 1 commit into from

Conversation

skhomuti
Copy link
Contributor

@skhomuti skhomuti commented Mar 15, 2024 •
edited
Loading

due to the possibility of unwrapping wsteth right in the UI, it is decided to remove wsteth at all from the onchain code in order to reduce contract sizes and complexities

| CSAccounting               | 20.292    | 4.284       |
| CSModule                   | 23.496    | 1.08        |
--->>>
| CSAccounting               | 18.617    | 5.959       |
| CSModule                   | 22.97     | 1.606       |

@skhomuti skhomuti requested a review from a team as a code owner March 15, 2024 10:51
dgusakov
dgusakov requested changes Mar 15, 2024
View reviewed changes
src/CSBondCore.sol Outdated Show resolved Hide resolved
@skhomuti skhomuti changed the title Remove wsteth Remove wsteth deposits Mar 15, 2024
dgusakov
dgusakov requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dgusakov dgusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given Izzy's comments let's postpone this PR for now

@skhomuti skhomuti marked this pull request as draft March 25, 2024 04:23
@skhomuti skhomuti closed this Apr 1, 2024
@skhomuti skhomuti deleted the remove-wsteth branch April 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgusakov dgusakov dgusakov requested changes

@madlabman madlabman Awaiting requested review from madlabman madlabman is a code owner automatically assigned from lidofinance/community-staking

@vgorkavenko vgorkavenko Awaiting requested review from vgorkavenko vgorkavenko is a code owner automatically assigned from lidofinance/community-staking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skhomuti @dgusakov