feat: validator's withdrawal proof #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhomuti
reviewed
Jan 9, 2024
madlabman
force-pushed
the
withdrawal-proof
branch
2 times, most recently
from
cfa0da1 to
16a03be
Compare
dgusakov
reviewed
Jan 10, 2024
skhomuti
force-pushed
the
withdrawal-methods
branch
from
66fa9c0 to
2aa0c1e
Compare
skhomuti
requested changes
Jan 11, 2024
vgorkavenko
reviewed
Jan 11, 2024
madlabman
force-pushed
the
withdrawal-proof
branch
2 times, most recently
from
3629fe1 to
7dd1094
Compare
madlabman
force-pushed
the
withdrawal-proof
branch
14 times, most recently
from
59c595b to
eceb82f
Compare
madlabman
force-pushed
the
withdrawal-proof
branch
from
eceb82f to
5f55136
Compare
vgorkavenko
reviewed
Feb 6, 2024
vgorkavenko
previously approved these changes
Feb 7, 2024
skhomuti
requested changes
Feb 8, 2024
skhomuti
approved these changes
Feb 19, 2024
vgorkavenko
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tentatively decided to hardcode via deployment the deneb's generalized indices. The motivation is:
BeaconBlockhas 5 fields and has no changes since phase0;BeaconStatehas 28 fields, so there are 4 fields left before shifting of a tree;ExecutionPayloadHeaderhas 17 fields since deneb, so there's a huge gap to the future;