-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSFeeOracle based on BaseOracle and HashConsensus #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madlabman
force-pushed
the
feat/hash-consensus
branch
2 times, most recently
from
November 1, 2023 19:04
ae3df1d
to
ef1bc0d
Compare
vgorkavenko
reviewed
Nov 2, 2023
madlabman
force-pushed
the
feat/hash-consensus
branch
2 times, most recently
from
November 2, 2023 15:24
bcb86d9
to
4c67a97
Compare
madlabman
force-pushed
the
feat/hash-consensus
branch
from
November 2, 2023 15:30
4c67a97
to
08a0593
Compare
madlabman
force-pushed
the
feat/hash-consensus
branch
2 times, most recently
from
November 6, 2023 19:54
4dc3097
to
16c9b40
Compare
vgorkavenko
reviewed
Nov 7, 2023
madlabman
force-pushed
the
feat/hash-consensus
branch
from
November 7, 2023 08:51
16c9b40
to
657e18d
Compare
vgorkavenko
approved these changes
Nov 7, 2023
skhomuti
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lido v2 introduced several new contracts for oracles, including
HashConsensus
andBaseOracle
. To make use of that, the set of contracts copied in the source tree underlib/base-oracle
directory. OpenZeppelin contracts of version 4.4.1 added separately to resolve dependencies of the copied contracts (seeremappings.txt
). Only change for lido-dao contracts made is changing compiler version from0.8.9
to^0.8.9
to be able to seamlessly import the contracts.The flow for the off-chain part may look like this:
oracle.treeCid
and downloads previous report data if any.getFrameConfig.initialEpoch
by traversing frames one by one.