Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-78 feat: required bond methods #28

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Conversation

vgorkavenko
Copy link
Contributor

No description provided.

@vgorkavenko vgorkavenko marked this pull request as draft October 10, 2023 14:55
@vgorkavenko vgorkavenko force-pushed the feat/required-bond-view-methods branch 2 times, most recently from d034775 to 7ff084f Compare October 12, 2023 15:40
@vgorkavenko vgorkavenko marked this pull request as ready for review October 12, 2023 15:42
Copy link
Contributor

@dgusakov dgusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to find +1 wei in the code

src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
@vgorkavenko vgorkavenko force-pushed the feat/required-bond-view-methods branch from 05b53b3 to 535852a Compare October 13, 2023 11:02
@vgorkavenko vgorkavenko force-pushed the feat/required-bond-view-methods branch from 535852a to 41c3d89 Compare October 13, 2023 11:20
@vgorkavenko vgorkavenko requested review from a team, madlabman and dgusakov October 16, 2023 10:36
@vgorkavenko vgorkavenko changed the title feat: required bond methods CS-78 feat: required bond methods Oct 16, 2023
.gitignore Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
skhomuti
skhomuti previously approved these changes Oct 18, 2023
src/CommunityStakingBondManager.sol Show resolved Hide resolved
skhomuti
skhomuti previously approved these changes Oct 23, 2023
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
src/CommunityStakingBondManager.sol Outdated Show resolved Hide resolved
dgusakov
dgusakov previously approved these changes Oct 24, 2023
skhomuti
skhomuti previously approved these changes Oct 24, 2023
@vgorkavenko vgorkavenko requested a review from madlabman October 24, 2023 13:26
test/BondManager.t.sol Outdated Show resolved Hide resolved
test/BondManager.t.sol Show resolved Hide resolved
test/BondManager.t.sol Show resolved Hide resolved
test/BondManager.t.sol Show resolved Hide resolved
test/BondManager.t.sol Show resolved Hide resolved
Copy link
Contributor

@madlabman madlabman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@vgorkavenko vgorkavenko merged commit 162d36e into main Oct 24, 2023
@vgorkavenko vgorkavenko deleted the feat/required-bond-view-methods branch October 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants