Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deposit queue (CS-55) #18

Merged
merged 29 commits into from
Oct 26, 2023
Merged

feat: deposit queue (CS-55) #18

merged 29 commits into from
Oct 26, 2023

Conversation

madlabman
Copy link
Contributor

No description provided.

@madlabman madlabman force-pushed the feat/deposit-queue branch 4 times, most recently from 21df19f to 573ef65 Compare September 19, 2023 07:08
src/lib/Batch.sol Outdated Show resolved Hide resolved
src/Queue.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
@vgorkavenko
Copy link
Contributor

Not an observation, just a reminder for all of us. It would be nice to have minimal docs for the main functions of sophisticated algorithm, especially for non-obvious ones. I am well aware that this is a draft, but maybe at least an high-level describing the basic idea. WDYT?

src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/Queue.sol Outdated Show resolved Hide resolved
src/Queue.sol Outdated Show resolved Hide resolved
src/lib/Batch.sol Outdated Show resolved Hide resolved
test/Batch.t.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
@madlabman madlabman requested a review from dgusakov October 11, 2023 09:31
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/lib/Batch.sol Show resolved Hide resolved
@madlabman madlabman requested a review from skhomuti October 12, 2023 06:53
skhomuti
skhomuti previously approved these changes Oct 12, 2023
@dgusakov dgusakov changed the title feat: deposit queue feat: deposit queue (CS-55) Oct 13, 2023
vgorkavenko
vgorkavenko previously approved these changes Oct 16, 2023
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Outdated Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
src/CommunityStakingModule.sol Show resolved Hide resolved
@madlabman madlabman dismissed stale reviews from vgorkavenko and skhomuti via c29bccc October 25, 2023 16:27
@madlabman madlabman merged commit 1cb05ae into main Oct 26, 2023
4 checks passed
@madlabman madlabman deleted the feat/deposit-queue branch October 26, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants