Skip to content

Commit

Permalink
chore: move linters to dev dependencies (#360)
Browse files Browse the repository at this point in the history
Note that both `yarn install` and `yarn install --immutable` install
**all** dependencies, including the development ones. Use `yarn
workspaces focus --all --production` instead.
  • Loading branch information
madlabman authored Oct 21, 2024
1 parent ac38c39 commit cf61424
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
cache-dependency-path: "**/yarn.lock"

- name: Install dependencies
run: just deps
run: just deps-dev

- name: Linters check
run: just lint
Expand Down
5 changes: 4 additions & 1 deletion Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ clean:
rm -rf cache broadcast out node_modules

deps:
yarn install --immutable
yarn workspaces focus --all --production

deps-dev:
yarn workspaces focus --all && npx husky install

lint-solhint:
yarn lint:solhint
Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@
"lint:check": "prettier --check **.sol && yarn lint:solhint",
"lint:fix": "prettier --write **.sol",
"generate:diffyscan": "node script/generateDiffyscanContracts.js",
"gindex": "node script/gindex.mjs",
"postinstall": "husky install"
"gindex": "node script/gindex.mjs"
},
"devDependencies": {
"dependencies": {
"@lodestar/types": "^1.18.1",
"@openzeppelin/contracts": "5.0.2",
"@openzeppelin/contracts-upgradeable": "5.0.2",
"@openzeppelin/merkle-tree": "^1.0.6",
"ds-test": "https://github.com/dapphub/ds-test",
"forge-std": "https://github.com/foundry-rs/forge-std.git#v1.7.6",
"forge-std": "https://github.com/foundry-rs/forge-std.git#v1.7.6"
},
"devDependencies": {
"husky": "^8.0.3",
"lint-staged": "^14.0.1",
"prettier": "^3.0.3",
Expand Down

0 comments on commit cf61424

Please sign in to comment.