fix: zero-out targetLimit earlier

lidofinance · Oct 1, 2024 · 04c57a3 · 04c57a3
1 parent cdc6e33
commit 04c57a3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/src/CSModule.sol b/src/CSModule.sol
@@ -808,6 +808,10 @@ contract CSModule is
         _onlyExistingNodeOperator(nodeOperatorId);
         NodeOperator storage no = _nodeOperators[nodeOperatorId];
 
+        if (targetLimitMode == 0) {
+            targetLimit = 0;
+        }
+
         if (
             no.targetLimitMode == targetLimitMode &&
             no.targetLimit == targetLimit
@@ -818,10 +822,6 @@ contract CSModule is
             no.targetLimitMode = uint8(targetLimitMode);
         }
 
-        if (targetLimitMode == 0) {
-            targetLimit = 0;
-        }
-
         if (no.targetLimit != targetLimit) {
             // @dev No need to safe cast due to conditions above
             no.targetLimit = uint32(targetLimit);

diff --git a/test/CSModule.t.sol b/test/CSModule.t.sol
@@ -4963,6 +4963,25 @@ contract CsmUpdateTargetValidatorsLimits is CSMCommon {
         csm.updateTargetValidatorsLimits(noId, 1, 0);
     }
 
+    function test_updateTargetValidatorsLimits_FromDisabledToDisabled_withNonZeroTargetLimit()
+        public
+        assertInvariants
+    {
+        uint256 noId = createNodeOperator();
+        csm.updateTargetValidatorsLimits(noId, 2, 10);
+
+        vm.expectEmit(true, true, true, true, address(csm));
+        emit CSModule.TargetValidatorsCountChanged(noId, 0, 0);
+        csm.updateTargetValidatorsLimits(noId, 0, 0);
+
+        vm.recordLogs();
+        csm.updateTargetValidatorsLimits(noId, 0, 8);
+        assertEq(vm.getRecordedLogs().length, 0);
+
+        NodeOperator memory no = csm.getNodeOperator(noId);
+        assertEq(no.targetLimit, 0);
+    }
+
     function test_updateTargetValidatorsLimits_enableSoftLimit()
         public
         assertInvariants