feat: add mellow-vaults bot scaffold

.github/CODEOWNERS

@@ -14,7 +14,7 @@
 /ethereum-financial/ @lidofinance/lido-eth-protocol
 /arb-subgraph/ @lidofinance/lido-si
 /ethereum-governance/ @lidofinance/lido-dao-ops-team
-/ethereum-governance-v2/ @lidofinance/lido-dao-ops-team
+/mellow-vaults/ @lidofinance/lido-dao-ops-team
 /multisig-watcher/ @lidofinance/lido-dao-ops-team
 /voting-watcher/ @lidofinance/lido-dao-ops-team
 /ethereum-validators-set/ @lidofinance/lido-tooling

ethereum-governance/src/services/acl-changes/AclChanges.spec.ts

@@ -130,7 +130,7 @@ describe('AclChangesSrv', () => {
     jest.spyOn(ethProvider, 'getContractOwner').mockResolvedValue(E.left(new Error('Test error')))
     const finding = networkAlert(
       new Error('Test error'),
-      `Error in AclChangesSrv.handleOwnerChange (uid:790dc305)`,
+      `Error in AclChangesSrv.handleOwnerChange (uid:3197e652)`,
       `Could not call ethProvider.getOwner for address - ${dsAddress}`,
     )
 

ethereum-governance/src/services/acl-changes/AclChanges.srv.ts

@@ -177,14 +177,19 @@ export class AclChangesSrv {
         out.push(
           networkAlert(
             curOwner.left,
-            `Error in ${AclChangesSrv.name}.${this.handleOwnerChange.name} (uid:790dc305)`,
+            `Error in ${AclChangesSrv.name}.${this.handleOwnerChange.name} (uid:3197e652)`,
             `Could not call ethProvider.getOwner for address - ${address}`,
           ),
         )
         return
       }
 
-      if (WHITELISTED_OWNERS.includes(curOwner.right.toLowerCase())) {
+      const curOwnerAddress = curOwner.right.toLowerCase()
+      if (data?.ownerAddress && data?.ownerAddress === curOwnerAddress) {
+        return
+      }
+
+      if (!data?.ownerAddress && WHITELISTED_OWNERS.includes(curOwnerAddress)) {
         return
       }
 

ethereum-governance/src/shared/constants/acl-changes/mainnet.ts

@@ -35,6 +35,8 @@ import {
   ANCHOR_VAULT_ADDRESS as anchorVaultAddress,
   EMERGENCY_BRAKES_MS_ADDRESS as emergencyMsAddress,
   DEV_MS_ADDRESS as devMsAddress,
+  MELLOW_VAULT_PROXY_ADDRESS as vaultProxyAddress,
+  MELLOW_VAULT_PROXY_OWNER as vaultProxyOwner,
 } from 'constants/common'
 
 export const NEW_OWNER_IS_CONTRACT_REPORT_INTERVAL = 24 * 60 * 60 // 24h
@@ -133,6 +135,7 @@ export const LIDO_ROLES = new Map([
 export interface IOwnable {
   name: string
   ownershipMethod: string
+  ownerAddress?: string
 }
 
 // List of contracts to monitor for owner
@@ -194,17 +197,25 @@ export const OWNABLE_CONTRACTS = new Map<string, IOwnable>([
     },
   ],
   [
-    anchorVaultAddress,
+    evmExecutorAddress,
     {
-      name: 'AnchorVault',
-      ownershipMethod: 'admin',
+      name: 'Easy Track EVMScriptExecutor',
+      ownershipMethod: 'owner',
     },
   ],
   [
-    evmExecutorAddress,
+    vaultProxyAddress,
     {
-      name: 'Easy Track EVMScriptExecutor',
+      name: 'Mellow Vault upgradeable Proxy Admin',
       ownershipMethod: 'owner',
+      ownerAddress: vaultProxyOwner,
+    },
+  ],
+  [
+    anchorVaultAddress,
+    {
+      name: 'AnchorVault',
+      ownershipMethod: 'admin',
     },
   ],
   [

ethereum-governance/src/shared/constants/common/mainnet.ts

@@ -61,6 +61,9 @@ export const USDC_ADDRESS = '0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48'
 export const EMERGENCY_BRAKES_MS_ADDRESS = '0x73b047fe6337183a454c5217241d780a932777bd'
 export const DEV_MS_ADDRESS = '0x3cd9f71f80ab08ea5a7dca348b5e94bc595f26a0'
 
+export const MELLOW_VAULT_PROXY_ADDRESS = '0xed792a3fdeb9044c70c951260aaae974fb3db38f'
+export const MELLOW_VAULT_PROXY_OWNER = '0x81698f87c6482bf1ce9bfcfc0f103c4a0adf0af0'
+
 // COMMON CONSTS
 export const BN_ZERO = new BigNumber(0)
 export const RUN_TIER = process.env.FORTA_AGENT_RUN_TIER

mellow-vaults/.dockerignore

@@ -0,0 +1,3 @@
+node_modules/
+dist/
+forta.config.json

mellow-vaults/.eslintrc.json

@@ -0,0 +1,14 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier"],
+  "plugins": ["@typescript-eslint", "prettier"],
+  "env": {
+    "node": true,
+    "es6": true
+  },
+  "rules": {
+    "prettier/prettier": "error",
+    "curly": "error",
+    "semi": "off"
+  }
+}

mellow-vaults/.gitignore

@@ -0,0 +1,10 @@
+node_modules
+dist
+forta.config.json
+.yarn/*
+!.yarn/releases/
+*.log
+version.json
+.DS_Store
+/coverage/
+/src/generated/

mellow-vaults/.nvmrc

@@ -0,0 +1 @@
+v20.10.0

mellow-vaults/.prettierrc.json

@@ -0,0 +1,7 @@
+{
+  "semi": false,
+  "trailingComma": "all",
+  "singleQuote": true,
+  "printWidth": 120,
+  "tabWidth": 2
+}

mellow-vaults/Dockerfile

@@ -0,0 +1,22 @@
+# Build stage: compile Typescript to Javascript
+FROM node:20.10.0-alpine3.18 AS builder
+
+WORKDIR /app
+
+COPY . .
+RUN yarn install --immutable && yarn run build
+# Build app
+RUN yarn run build
+
+# Final stage: copy compiled Javascript from previous stage and run the app
+FROM node:20.10.0-alpine3.18 as production
+LABEL "network.forta.settings.agent-logs.enable"="true"
+ENV NODE_ENV=production
+WORKDIR /app
+
+COPY package*.json yarn.lock ./
+COPY --from=builder /app/node_modules ./node_modules
+COPY --from=builder /app/dist ./src
+COPY version.json ./
+
+CMD ["yarn", "run", "start:prod"]

mellow-vaults/README.md

@@ -0,0 +1,83 @@
+# Lido x Mellow Detection Bot for Forta
+
+## Supported chains
+
+- Ethereum mainnet
+
+## Alerts
+
+1. Aave operations
+   1. HandleBlock
+      1. 🚨🚨🚨 astETH balance - astETH totalSupply >= 1ETH
+      2. 🚨🚨🚨 stableDebtStETH totalSupply is not 0
+      3. 🚨🚨🚨 variableDebtStETH totalSupply is not 0
+2. Pool balances
+   1. HandleBlock
+      1. 🚨 Super low stETH:ETH price on Curve
+      2. 🚨 Super low stETH:ETH price on Chainlink
+      3. 🚨 Curve Pool rapid imbalance change
+      4. 🚨️ Significant Curve Pool size change
+      5. ⚠️ Significant Curve Pool size change
+      6. ⚠️ Curve Pool is imbalanced
+      7. ⚠️ stETH:ETH price on Curve decreased
+      8. ⚠️ stETH:ETH price on Chainlink decreased
+
+## Development
+
+Install deps:
+
+```
+yarn install
+```
+
+### Mainnet
+
+Edit `alerting-forta/<SUBMODULE>/forta.config.json` and set `jsonRpcUrl` to your Mainnet JSON-RPC provider.
+
+Running in a live mode:
+
+```
+yarn start:dev
+```
+
+Testing on a specific block/range/transaction:
+
+```
+yarn block 13626668
+yarn range '13626667..13626668'
+yarn tx 0x2d2774c04e3faf9f17cd26e0978bb812081b9d0b5cc6fd8bf04cc441f92c0a8c
+```
+
+### Testnet
+
+For example, you need to add `testnet` tier support for some new sub-agent:
+
+1. Change default import from `./constants` to `requireWithTier` function call:
+   ##### Before:
+   ```typescript
+   import {
+     NODE_OPERATORS_REGISTRY_ADDRESS,
+     EASY_TRACK_ADDRESS,
+     MOTION_ENACTED_EVENT,
+     SIGNING_KEY_REMOVED_EVENT,
+     NODE_OPERATOR_STAKING_LIMIT_SET_EVENT,
+     NODE_OPERATORS_REGISTRY_EVENTS_OF_NOTICE,
+   } from './constants'
+   ```
+   ##### After:
+   ```typescript
+   import type * as Constants from './constants'
+   const {
+     NODE_OPERATORS_REGISTRY_ADDRESS,
+     EASY_TRACK_ADDRESS,
+     MOTION_ENACTED_EVENT,
+     SIGNING_KEY_REMOVED_EVENT,
+     NODE_OPERATOR_STAKING_LIMIT_SET_EVENT,
+     NODE_OPERATORS_REGISTRY_EVENTS_OF_NOTICE,
+   } = requireWithTier<typeof Constants>(module, './constants')
+   ```
+2. Copy `./constants.ts` file to `./constants.testnet.ts` and change the addresses and other vars to the testnet ones.
+3. Edit `alerting-forta/<SUBMODULE>/forta.config.json` and set `jsonRpcUrl` to your Testnet JSON-RPC provider.
+4. Run `export FORTA_AGENT_RUN_TIER=testnet && yarn start:dev`
+
+That's it! Only sub-agents that have `testnet` tier support will be run.

mellow-vaults/jest.config-e2e.json

@@ -0,0 +1,12 @@
+{
+  "moduleFileExtensions": ["js", "json", "ts"],
+  "moduleDirectories": ["node_modules", "src"],
+  "testEnvironment": "node",
+  "testRegex": ".e2e-spec.ts$",
+  "preset": "ts-jest",
+  "testPathIgnorePatterns": ["dist"],
+  "moduleNameMapper": {
+    "^src/(.*)": "<rootDir>/src/$1",
+    "constants/common": "<rootDir>/src/shared/constants/common/mainnet"
+  }
+}

mellow-vaults/jest.config.js

@@ -0,0 +1,9 @@
+/** @type {import("ts-jest").JestConfigWithTsJest} */
+module.exports = {
+  preset: 'ts-jest',
+  testEnvironment: 'node',
+  testPathIgnorePatterns: ['dist'],
+  moduleNameMapper: {
+    'constants/common': '<rootDir>/src/shared/constants/common/mainnet',
+  },
+}

mellow-vaults/package.json

@@ -0,0 +1,97 @@
+{
+  "name": "lido-governance-forta-bot",
+  "version": "1.0.0",
+  "description": "Forta Bot for Lido protocol governance",
+  "repository": {
+    "type": "git",
+    "directory": "https://github.com/lidofinance/alerting-forta/tree/main/ethereum-steth"
+  },
+  "license": "MIT",
+  "chainIds": [
+    1
+  ],
+  "chainSettings": {
+    "default": {
+      "shards": 1,
+      "target": 5
+    }
+  },
+  "husky": {
+    "hooks": {
+      "pre-commit": "yarn run lint"
+    }
+  },
+  "scripts": {
+    "update-version": "node ../utils/write-version.js",
+    "build": "tsc && tsc-alias && yarn run copy-version",
+    "copy-version": "cp version.json dist",
+    "start": "yarn run update-version && yarn run start:dev",
+    "start:dev": "nodemon --watch src --watch forta.config.json -e js,ts,json  --exec \"yarn run build && yarn run copy-version && forta-agent run\"",
+    "start:prod": "forta-agent run --prod",
+    "tx": "yarn run build && forta-agent run --tx",
+    "block": "yarn run build && forta-agent run --block",
+    "range": "yarn run build && forta-agent run --range",
+    "alert": "yarn run build && forta-agent run --alert",
+    "sequence": "yarn run build && forta-agent run --sequence",
+    "file": "yarn run build && forta-agent run --file",
+    "publish": "yarn run update-version && forta-agent publish",
+    "info": "forta-agent info",
+    "logs": "forta-agent logs",
+    "push": "yarn run update-version && forta-agent push",
+    "disable": "forta-agent disable",
+    "enable": "forta-agent enable",
+    "keyfile": "forta-agent keyfile",
+    "stake": "forta-agent stake",
+    "test": "jest --passWithNoTests",
+    "test:e2e": "yarn build && jest --config ./jest.config-e2e.json --passWithNoTests",
+    "generate-types": "typechain --target=ethers-v5 --out-dir=./src/generated ./src/abi/*",
+    "eslint:lint": "eslint ./src ./tests",
+    "eslint:format": "eslint ./src ./tests --fix",
+    "prettier:check": "prettier --check ./src ./tests",
+    "prettier:format": "prettier --write ./src ./tests README.md",
+    "lint": "yarn run prettier:check && yarn run eslint:lint",
+    "format": "yarn run eslint:format && yarn run prettier:format",
+    "postinstall": "yarn generate-types"
+  },
+  "dependencies": {
+    "@ethersproject/abi": "^5.0.0",
+    "@ethersproject/providers": "^5.0.0",
+    "@types/lodash": "^4.14.202",
+    "async-mutex": "^0.4.0",
+    "bignumber.js": "^9.1.2",
+    "ethers": "^5.5.1",
+    "forta-agent": "^0.1.48",
+    "fp-ts": "^2.16.1",
+    "knex": "^3.1.0",
+    "lodash": "^4.17.21",
+    "ts-retry": "^4.2.4",
+    "winston": "^3.11.0"
+  },
+  "devDependencies": {
+    "@faker-js/faker": "^8.3.1",
+    "@jest/globals": "^29.7.0",
+    "@tsconfig/node20": "^20.1.2",
+    "@typechain/ethers-v5": "^11.1.2",
+    "@types/jest": "^29.5.11",
+    "@types/nodemon": "^1.19.0",
+    "@types/ws": "^8.5.10",
+    "@typescript-eslint/eslint-plugin": "^6.12.0",
+    "@typescript-eslint/parser": "^6.12.0",
+    "eslint": "^8.54.0",
+    "eslint-config-prettier": "^9.0.0",
+    "eslint-plugin-jest": "^27.6.0",
+    "eslint-plugin-prettier": "^5.0.1",
+    "husky": "^8.0.3",
+    "jest": "^29.7.0",
+    "jest-resolve": "^29.7.0",
+    "nodemon": "^3.0.1",
+    "postinstall": "^0.8.0",
+    "prettier": "^3.1.0",
+    "ts-generator": "^0.1.1",
+    "ts-jest": "^29.1.2",
+    "tsc-alias": "^1.8.8",
+    "typechain": "^8.3.2",
+    "typescript": "^5.3.2"
+  },
+  "packageManager": "[email protected]"
+}