fixes for Bogo-Indian + Catalan #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Bogo-Indian and Catalan lines are mis-classified, especially those beginning with 1. d4 Nf6 2. c4 e6 3. g3 Bb4+ 4. Bd2 Be7 5. Bg2 d5. Mostly these are Bogo-Indian but some positions can be reached via a Catalan move order, starting: 1. d4 Nf6 2. c4 e6 3. g3 d5 4. Bg2 Be7 and should properly be classified as Catalans, mostly E08 but could be others including E06 and E09. Given the variety of transpositions, it is hard to make a correct classification and it is even possible in some cases the classification is ambiguous. However, I have done my best here to fix it up. Classifications follow Chessbase. There are likely to still be inaccuracies, but this PR should reduce the number of those. Currently many games wind up with something like E00, and are not recognized as either Bogo-Indian or Catalan.