Upgrade nokogiri to 1.16.5 to address CVE-2024-34459 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade is not critical, because it addresses and xmllint issue and nokogiri doesn't expose xmllint to us. Fixes https://github.com/github/licensed/security/dependabot/11
|
We can't do this without requiring Ruby 3.0, and I'm not sure that's a step we want to take. |
|
FWIW I dropped support for <3.0 in licensee awhile back licensee/licensee#694 ... 2.7 is EOL. |
|
@mlinksva That's good to know! Then I think it's worth taking that step here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade is not critical, because it addresses and xmllint issue
and nokogiri doesn't expose xmllint to us.
Fixes https://github.com/github/licensed/security/dependabot/11