Added SLE15-SP5 targets, newer Rubocop #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lslezak
commented
Apr 8, 2022
lslezak
commented
- Originally I just wanted to fix failing GitHub Actions caused by using an obsolete Ruby version (Factory moved from 2.7 to 3.1 quite some time ago)
- But the old Rubocop is not compatible with Ruby 3.1 so we need to upgrade to a newer one...
- Also some data in the *.gemspec were obsolete (email, URL)...
- And when touching this we could also update the OBS targets...
Use the %{rb_default_ruby_abi} RPM macro
- Added SLE15-SP5 target, "sle_latest" moved to SLE15-SP5 - Related to bsc#1198109
lslezak
commented
Apr 8, 2022
| spec.add_runtime_dependency("rake", "> 10.0", "< 99") | ||
| # enable MFA (2FA) authentication at rubygems.org | ||
| # see https://guides.rubygems.org/mfa-requirement-opt-in/ | ||
| spec.metadata["rubygems_mfa_required"] = "true" |
There was a problem hiding this comment.
This was automatically added by Rubocop, but IMHO it makes sense. See https://guides.rubygems.org/mfa-requirement-opt-in/ for more details.
Personally I have enabled MFA. @jreidinger @mvidner @imobachgs, what about you? Is this change OK?
There was a problem hiding this comment.
well, I would have to enable it, but not critical for me.
There was a problem hiding this comment.
Well, I haven't tried this option yet. Can we lock ourselves out if the other maintainers haven't either? 🤣
There was a problem hiding this comment.
You cannot lock out yourselves, if you do not use MFA then just enable it and then you can do whatever you need.
imobachgs
approved these changes
Apr 8, 2022
jreidinger
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.