Fix all deprecated functions in GTK3 <= 3.22 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besser82
force-pushed
the
bugfix/Werror
branch
7 times, most recently
from
41f80cd to
17b3218
Compare
besser82
changed the title
besser82
force-pushed
the
bugfix/Werror
branch
14 times, most recently
from
62eb296 to
0b4d8f1
Compare
- Remove obsolete gtk_container_set_resize_mode() - Replace gtk_widget_get_root_window()
besser82
force-pushed
the
bugfix/Werror
branch
6 times, most recently
from
7b56896 to
2c95d32
Compare
|
This PR is ready for review && merge now. ^_^ |
- Remove gtk_tree_view_set_rules_hint() - Remove gtk_window_set_has_resize_grip() - Replace gtk_alignment_new() - Replace gtk_alignment_set_padding() - Replace gtk_arrow_new() - Replace gtk_misc_set_alignment() - Replace gtk_misc_set_padding()
besser82
force-pushed
the
bugfix/Werror
branch
2 times, most recently
from
bcefe3b to
05846d5
Compare
besser82
changed the title
besser82
force-pushed
the
bugfix/Werror
branch
2 times, most recently
from
4abdd44 to
40d5827
Compare
- Replace gdk_cursor_new()
- Replace gtk_style_context_get_background_color()
- Replace gdk_device_manager_get_client_pointer() - Replace gdk_display_get_device_manager()
- Replace gtk_button_set_focus_on_click()
besser82
force-pushed
the
bugfix/Werror
branch
4 times, most recently
from
b0c43c8 to
9b49cbe
Compare
- Replace gdk_screen_get_height() - Replace gdk_screen_get_monitor_at_window() - Replace gdk_screen_get_monitor_geometry() - Replace gdk_screen_get_width() - Replace gdk_visual_get_best_depth()
- Replace gtk_menu_popup()
|
Is this still open? |
|
well, it was approved, but not merged and now it conflict in changes, so it need rebase on top of current master and merge it. |
|
@besser82 could I ask you to fix up conflicts? I would like to fix some parts of libyui-gtk and this is a useful PR to not to have to worry about already fixed deprecated warnings. |
|
@besser82 ping? Could you please rebase this change? |
|
Conflicts are here because of the missed merge. I think you can get the master for all of those files that are not part of the fixing. If you want to trace the changes the real difference is into package/libyui-gtk.changes:
|
|
@anaselli @Conan-Kudo I'll get back to this during beginning of the week. I think a lot of preprocessor conditionals can be removed now, as GTK v3.22 is the final release and was included in almost all recent enterprise Linux releases. |
|
@besser82 great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for GTK3-3.22 are on my next batch. This is ready to go now.