Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build: repo renamed, Ruby ABI macro #2

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Fix build: repo renamed, Ruby ABI macro #2

merged 2 commits into from
Feb 7, 2018

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Feb 6, 2018

No description provided.

@mvidner
Copy link
Member Author

mvidner commented Feb 6, 2018

@lslezak I also started fixing the SP3 image, trying to enable the 42.3 repo, but that change alone was not enough.

@lslezak
Adapt also the SLE12-SP3 image
14aacc5 
Import the expected GPG keys, avoid using blank cheque
"--gpg-auto-import-keys" option
@lslezak
Copy link
Member

lslezak commented Feb 7, 2018

  • Use rpm --import instead of --gpg-auto-import-keys (more secure, import the specific keys only instead of blindly importing any key)
  • Switched to openSUSE-42.3 for the SP3 build (fixed the same NON OSS issue as well)

mvidner
mvidner commented Feb 7, 2018
View reviewed changes
Copy link
Member Author

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@mvidner mvidner merged commit 9c00b1e into master Feb 7, 2018
@lslezak lslezak deleted the fix-bitrot branch February 7, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvidner @lslezak