improve operation cache touch #4359
Merged
+67
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a operation cache hit, we were only touching the hit itself. As a result, after some operations on a loaded image, the image itself could be forced out by the operations that had been performed on it, even though the underlying image was still being used. This PR makes cache touches also update the timestamps on all upstream operations, since the upstream operations are also being used (indirectly).
|
The libvips operation cache was adapted from the one in nip2 and was supposed to be useful for nip4. Now nip4 is (finally!!!) coming to life, of course I'm finding all kinds of issues with the libvips version of the cache. This PR stops animated GIF display forcing load operations out of the cache because of the constant |
kleisauke
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a operation cache hit, we were only touching the hit itself.
As a result, after some operations on a loaded image, the image itself could be forced out by the operations that had been performed on it, even though the underlying image was still being used.
This PR makes cache touches also update the timestamps on all upstream operations, since the upstream operations are also being used (indirectly).