Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side panel entity search for words containing hyphen #658

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

olovy
Copy link
Contributor

@olovy olovy commented Jul 3, 2020

Checklist:

  • I have run the unit tests. yarn test:unit
  • I have run the linter. yarn lint

Description

Solves

Fix search containing hyphen in side panel
example: Lill-arm should find Lill-armenien

Summary of changes

Make the condition matching "operator" handle hyphen correctly, i.e do not match inside words.
e.g. match "-armenien" but not "lill-armenien"

@olovy olovy requested a review from oBlissing July 3, 2020 15:25
@olovy olovy changed the title Fix side panel entity search with hyphen Fix side panel entity search for words containing hyphen Jul 3, 2020
Copy link
Contributor

@oBlissing oBlissing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oBlissing oBlissing merged commit 9d7b588 into develop Jul 6, 2020
@olovy olovy deleted the bugfix/entity-hyphen-search branch November 25, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants