feat(supersearch): Insert space before qualifier (LWS-286)

[jesperengstrom]

Description

Tickets involved

LWS-286

Solves

Avoids breaking a qualifier pill by typing stuff before it, inadvertently altering the qualifierKey.

Summary of changes

• Provide a insertSpaceBeforeQualifier function with the plugin - a transaction filter that checks if any atomic range overlaps the cursor position. If so, add a blank space at the position (before the pill).
• For easier access to the atomic ranges, we now build a separate range set while creating the widgets by using a RangeSetBuilder. This can then be passed directly to Editorview.atomicRanges and the insertSpace functions, and previous workarounds (atomic prop, filterAtomic function are no longer needed).
• Some general refactoring of the plugin.

[johanbissemattsson]

Great work (also with the usage of RangeSetBuilder)! 🙌

See comments regarding the number of spaces added.

[johanbissemattsson]

I get the feeling that one space to many is added when pressing space before a valid qualifier (when there should only be one?).

Changing line 18 to insert: '' and line 21 to selection: { anchor: oldCursorPos } makes it IMO feel more right – or what do you think? Hopefully it doesn't breaking something else...

[johanbissemattsson]

Edited the comment above now as I accidentally added a whitespace in-between the quotes (it should be insert: '' instead of insert: ' ')

[johanbissemattsson]

Hmm removing the changes property altogether maybe makes more sense? It seems to have the same effect:

const insertSpaceBeforeQualifier = (getRanges: () => RangeSet<RangeValue>) => {
	return EditorState.transactionFilter.of((tr) => {
		if (!tr.docChanged || (tr.isUserEvent('delete') && tr.state.selection.main.head === 0)) {
			return tr;
		} else {
			let insert = {};
			const atomicRanges = getRanges();
			const oldCursorPos = tr.startState.selection.main.head;

			atomicRanges.between(oldCursorPos, oldCursorPos, () => {
				insert = {
					sequential: true,
					selection: { anchor: oldCursorPos}
				};
				return false;
			});
			return [tr, insert];
		}
	});
};