Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine docker image version #631

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Add alpine docker image version #631

merged 12 commits into from
Aug 14, 2024

Conversation

rare-magma
Copy link
Contributor

@rare-magma rare-magma commented Jun 2, 2024

The alpine based php docker image results in a 5x reduction in image size when compared with the debian one (~125MB vs ~540MB)

@rare-magma rare-magma changed the title Add alpine docker image Add alpine docker image version Jun 2, 2024
Signed-off-by: rare-magma <[email protected]>
@sstidl
Copy link
Collaborator

sstidl commented Aug 10, 2024

thank you very much for contributing @rare-magma
i did look at the change but i cant see that you are creating the semver docker labels correctly.

the needed labels are
major
major.minor
major.minor.hotfix
major-alpine
major.minor-alpine
major.minor.hotfix-alpine
latest
latest-alpine

can you achive that?

Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
@rare-magma
Copy link
Contributor Author

@sstidl I've added the missing docker labels, could you please give it a try?

@sstidl
Copy link
Collaborator

sstidl commented Aug 13, 2024

@rare-magma i dont think i works as in your repo there are no tags matching the pattern. try to merge it in your master and make a release in your repo. then you should see something here: https://github.com/rare-magma/speedtest/pkgs/container/speedtest

@rare-magma
Copy link
Contributor Author

rare-magma commented Aug 13, 2024

@sstidl I've merged to main in my fork and it seems to work fine:

podman pull ghcr.io/rare-magma/speedtest:latest ghcr.io/rare-magma/speedtest:latest-alpine
podman images | grep speedtest
ghcr.io/rare-magma/speedtest   latest         3a7ff00e3229  12 minutes ago  518 MB
ghcr.io/rare-magma/speedtest   latest-alpine  d903eb3d8174  16 minutes ago  120 MB

@sstidl
Copy link
Collaborator

sstidl commented Aug 13, 2024

Looks good. You tagged v999.999.999

@rare-magma
Copy link
Contributor Author

@sstidl yes I created v999.999.999 as a test, I'll delete the fork and its packages later once this is merged

@sstidl
Copy link
Collaborator

sstidl commented Aug 13, 2024

The image building looks good now. Thank you!

I saw that you picked php8.2 in the Dockerfile for alpine. Is there a reason not to use 8.3 there?

Signed-off-by: rare-magma <[email protected]>
@rare-magma
Copy link
Contributor Author

@sstidl I've bumped it to 8.3 on 76bb7de

@sstidl sstidl merged commit 79436f0 into librespeed:master Aug 14, 2024
@sstidl
Copy link
Collaborator

sstidl commented Aug 14, 2024

@rare-magma thank you again for contributing. I just merged your changes.

We still need to add some documentation.
I would appreciate if you could add something about the alpine flavour to the docker Readme. If you have time.

@adolfintel FYI

@rare-magma
Copy link
Contributor Author

@sstidl I've created a PR with more info on the alpine variant: #654

@adolfintel
Copy link
Member

Yeah this looks absolutely fine :)

Sorry it took so long to merge it, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants