-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpine docker image version #631
Add alpine docker image version #631
Conversation
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
thank you very much for contributing @rare-magma the needed labels are can you achive that? |
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
@sstidl I've added the missing docker labels, could you please give it a try? |
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
@rare-magma i dont think i works as in your repo there are no tags matching the pattern. try to merge it in your master and make a release in your repo. then you should see something here: https://github.com/rare-magma/speedtest/pkgs/container/speedtest |
@sstidl I've merged to main in my fork and it seems to work fine:
|
Looks good. You tagged v999.999.999 |
@sstidl yes I created v999.999.999 as a test, I'll delete the fork and its packages later once this is merged |
The image building looks good now. Thank you! I saw that you picked php8.2 in the Dockerfile for alpine. Is there a reason not to use 8.3 there? |
Signed-off-by: rare-magma <[email protected]>
@rare-magma thank you again for contributing. I just merged your changes. We still need to add some documentation. @adolfintel FYI |
Yeah this looks absolutely fine :) Sorry it took so long to merge it, thanks for your contribution. |
The alpine based php docker image results in a 5x reduction in image size when compared with the debian one (~125MB vs ~540MB)