Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use tokio instead of async-std #5828

Merged
merged 4 commits into from
Jan 29, 2025
Merged

chore: use tokio instead of async-std #5828

merged 4 commits into from
Jan 29, 2025

Conversation

kamuik16
Copy link
Contributor

Description

ref #4449

dariusc93
dariusc93 reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a question on whether we should use tokio::test macro instead for the tests.

core/tests/transport_upgrade.rs Outdated Show resolved Hide resolved
jxs
jxs approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Krishang, I'll let you address Darius suggestion

dariusc93
dariusc93 reviewed Jan 28, 2025
View reviewed changes
misc/connection-limits/src/lib.rs Show resolved Hide resolved
misc/connection-limits/src/lib.rs Outdated Show resolved Hide resolved
@kamuik16
Copy link
Contributor Author

Hey @jxs, I think @dariusc93's comments are resolved, gtg :)

@jxs jxs added the send-it label Jan 29, 2025
@mergify mergify bot merged commit c625951 into libp2p:master Jan 29, 2025
71 checks passed
@kamuik16 kamuik16 deleted the krishang/tokio branch January 29, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamuik16 @jxs @dariusc93