-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: deduplicate dependencies #5318
Conversation
Signed-off-by: onur-ozkan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks for your interest! As we use dependabot to submit PR's with updates for the dependencies I don't think this is worth it.
If we downgrade tempfile
dependabot will submit a PR trying to update it afaik, trying to keep track of downgraded packages and keeping ignoring upgrades for certain so that we have less package versions on Cargo.lock
is therefore not worth it imho.
Only the 2nd commit downgrades a dependency as pointed out at #5318 (comment). I will revert that commit since the repo has dependabot integration. |
f26da41
to
2d9c41c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ping @jxs for stalled PR |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Helps to reduce number of dependencies by removing duplicated ones. Pull-Request: libp2p#5318.
Description
Helps to reduce number of dependencies by removing duplicated ones.