Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kad): wake Handler after pushing into pending_messages #4961

Closed
wants to merge 1 commit into from
Closed

fix(kad): wake Handler after pushing into pending_messages #4961

wants to merge 1 commit into from

Conversation

stormshield-frb
Copy link
Contributor

@stormshield-frb stormshield-frb commented Nov 29, 2023 •
edited by thomaseizinger
Loading

Description

Fixes: #4960.

Notes & open questions

N/A

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@stormshield-frb stormshield-frb force-pushed the fix/pending-messages-might-be-not-detected branch from 21778f0 to f6bc4e3 Compare November 29, 2023 15:49
@thomaseizinger
Copy link
Contributor

Finding all the bugs in my code @stormshield-frb ! 🙈

@thomaseizinger thomaseizinger changed the title fix(kad): pushing to pending_messages do not wake up Handler::poll fix(kad): wake Handler after pushing into pending_messages Nov 29, 2023
thomaseizinger
thomaseizinger reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

I wonder if this is worth testing writing a test for although I am not sure how exactly we'd write one.

protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
protocols/kad/src/handler.rs Show resolved Hide resolved
protocols/kad/src/handler.rs Outdated Show resolved Hide resolved
protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
@stormshield-frb stormshield-frb force-pushed the fix/pending-messages-might-be-not-detected branch 2 times, most recently from 6c2da35 to cccf87b Compare November 30, 2023 09:23
thomaseizinger
thomaseizinger reviewed Dec 1, 2023
View reviewed changes
protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
protocols/kad/src/handler.rs Outdated Show resolved Hide resolved
@stormshield-frb stormshield-frb force-pushed the fix/pending-messages-might-be-not-detected branch from cccf87b to 77c734d Compare December 1, 2023 08:27
@stormshield-frb stormshield-frb force-pushed the fix/pending-messages-might-be-not-detected branch from 77c734d to d1e3ea7 Compare December 1, 2023 08:28
@mxinden mxinden mentioned this pull request Dec 1, 2023
Closed
@thomaseizinger
Copy link
Contributor

As per discussion in #4960, I think we can close this as not necessary.

@stormshield-frb stormshield-frb deleted the fix/pending-messages-might-be-not-detected branch March 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger left review comments

@dariusc93 dariusc93 dariusc93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handeling of events received in kad::Handler could be delayed or blocked
3 participants
@stormshield-frb @thomaseizinger @dariusc93