chore(*): Run rustfmt 1.7.0 and clippy 0.1.76 #4907
Conversation
|
This single PR is so massive, it would probably be my biggest contribution (in the stats) by far, which is... interesting. |
Me too and I am somewhat surprised that the Rust team would ship that!
Can you extract that into a separate PR (and bump the nightly clippy version in CI). We will update to clippy once 1.75 is stable so we might as well fix those lints early. |
|
This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏 |
Should we open an issue with them, if there isn't one already?
Will do, some of the remaining lints need manual fixing though and will introduce breaking changes in public APIs. |
I think it may come as part of the next edition which would allow for such changes to be made AFAIK.
Happy to merge the easy ones first and hold off on all the breaking ones until we do another release. |
|
This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏 |
|
closing as stale |
Description
Ran cargo fmt and cargo clippy --fix with the respective new nightly versions.
Notes & open questions
While I have no issues with the fixes introduced by clippy, I have issues with the new rustfmt version.
As you can see the changes are quite severe and the change in style is stronger then in previous releases.
We should be careful when merging into master, because every PR that doesn't use the nightly compiler and runs the format will probably have a merge conflict. But we probably have to do it eventually.
An upside of the changes, at least from my POV is that changes are now spread over more lines, which could be beneficial for merge conflict resolution.
I would suggest we keep this PR open and I update it regularly with the nightly versions of rustfmt. It's a lot of work to merge that probably, so I'd suggest we merge the version that will be released eventually.
Change checklist