Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set idle_connection_timeout in examples #4887

Merged
merged 7 commits into from
Nov 21, 2023
Merged

fix: set idle_connection_timeout in examples #4887

merged 7 commits into from
Nov 21, 2023

Conversation

snowmead
Copy link
Contributor

@snowmead snowmead commented Nov 17, 2023 •
edited by thomaseizinger
Loading

Description

Within examples, we often set up a very specific network configuration which may leave connections idle whilst we wait for user input. To ensure that the examples can still showcase something, we need to set an idle_connection_timeout on the Swarm.

Related: #4877.

@snowmead snowmead changed the title Add connection timeout to swarm configs in example fix: Add connection timeout to swarm configs in example Nov 17, 2023
@thomaseizinger thomaseizinger mentioned this pull request Nov 19, 2023
Closed
4 tasks
thomaseizinger
thomaseizinger reviewed Nov 19, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just two comments.

examples/upnp/src/main.rs Outdated Show resolved Hide resolved
examples/relay-server/src/main.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix: Add connection timeout to swarm configs in example fix: set idle_connection_timeout in examples Nov 19, 2023
thomaseizinger
thomaseizinger previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should probably update the docs of the with_idle_connection_timeout function to explain a bit more what is happening there.

@mergify mergify bot dismissed thomaseizinger’s stale review November 20, 2023 23:10

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 3e30c20 into libp2p:master Nov 21, 2023
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowmead @thomaseizinger