Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new header to changelog of each crate #4690

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

thomaseizinger
Copy link
Contributor

Description

Adds a new header with the correct version to each changelog, otherwise the new lint will fail on all of these crates. We also specify a cargo release "pre-release-hook" to automate this. All you need to do is run cargo release hook for the same crates that you are running cargo release version on.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Oct 20, 2023
@thomaseizinger thomaseizinger modified the milestone: v0.53.0 Oct 20, 2023
@mergify mergify bot merged commit 2a7291a into master Oct 20, 2023
72 checks passed
@mergify mergify bot deleted the chore/fix-changelogs branch October 20, 2023 01:21
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. thanks

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
Adds a new header with the correct version to each changelog, otherwise the new lint will fail on all of these crates. We also specify a `cargo release` "pre-release-hook" to automate this. All you need to do is run `cargo release hook` for the same crates that you are running `cargo release version` on.

Pull-Request: libp2p#4690.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants