Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dcutr): exchange address candidates #4624

Merged
merged 22 commits into from
Oct 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5b9b8c0
Fix TODO
thomaseizinger Oct 11, 2023
377eb99
Use address candidates in dcutr
thomaseizinger Oct 11, 2023
a6b59d5
Remove log
thomaseizinger Oct 11, 2023
72d1f78
Reuse `is_relayed`
thomaseizinger Oct 11, 2023
507d46c
Extract dedicated `Candidates` struct
thomaseizinger Oct 11, 2023
4ee89b0
Update changelog and version
thomaseizinger Oct 11, 2023
987fc5f
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 15, 2023
d144362
Remove unnecessary `.clone`
thomaseizinger Oct 16, 2023
bfd6e8a
No longer add external address explicitly
thomaseizinger Oct 16, 2023
ffc5fa6
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 19, 2023
fd58272
Update protocols/dcutr/src/behaviour.rs
thomaseizinger Oct 19, 2023
5761253
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 20, 2023
35daa57
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 25, 2023
990ff07
Clarify log for @mxinden
thomaseizinger Oct 25, 2023
0c612ba
Apply suggestions from code review
thomaseizinger Oct 25, 2023
4367585
Ensure `src` and `dst` don't have external addresses
thomaseizinger Oct 25, 2023
9feb28b
Merge remote-tracking branch 'origin/fix/dcutr-candidates' into fix/d…
thomaseizinger Oct 25, 2023
4200e11
Add assertion
thomaseizinger Oct 25, 2023
5d975d3
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 25, 2023
bdad319
Merge branch 'master' into fix/dcutr-candidates
thomaseizinger Oct 26, 2023
b9e235f
Don't add external address
thomaseizinger Oct 26, 2023
221df28
Merge branch 'master' into fix/dcutr-candidates
mergify[bot] Oct 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No longer add external address explicitly
thomaseizinger committed Oct 16, 2023
commit bfd6e8a4efae0c597af0a3e23f45af16133e6efd
1 change: 0 additions & 1 deletion examples/dcutr/src/main.rs
Original file line number Diff line number Diff line change
@@ -157,7 +157,6 @@ async fn main() -> Result<(), Box<dyn Error>> {
..
})) => {
info!("Relay told us our public address: {:?}", observed_addr);
swarm.add_external_address(observed_addr);
learned_observed_addr = true;
}
event => panic!("{event:?}"),