Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(futures-bounded): add support for streams #4616

Merged
merged 21 commits into from
Oct 25, 2023
Merged

feat(futures-bounded): add support for streams #4616

merged 21 commits into from
Oct 25, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

This is the next logical extension to the futures-bounded crate by adding support for streams. For the moment, this isn't used in rust-libp2p but given that it is a general-purpose crate, putting this code here makes sense.

Related: firezone/firezone#2279.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title feat(futures-bounded): extend with streams feat(futures-bounded): add support for streams Oct 10, 2023
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger mentioned this pull request Oct 10, 2023
Merged
@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Oct 23, 2023
@thomaseizinger
Copy link
Contributor Author

Friendly ping @mxinden.

@thomaseizinger thomaseizinger mentioned this pull request Oct 23, 2023
Merged
4 tasks
mxinden
mxinden approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Sorry for the delay. Thank you for the work

misc/futures-bounded/src/lib.rs Outdated Show resolved Hide resolved
misc/futures-bounded/src/stream_set.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 8b3d4e4 into master Oct 25, 2023
71 checks passed
@mergify mergify bot deleted the feat/stream-map branch October 25, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden