feat(gossipsub)!: return typed error from config builder #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you!
This is a breaking change so we'll queue it for the next release. I'll thus mark it is draft so that it doesn't get merged accidentally.
Can you please bump the version of libp2p-gossipsub accordingly and also write a changelog entry? See https://github.com/libp2p/rust-libp2p/blob/master/CONTRIBUTING.md#write-changelog-entries-for-user-facing-changes for details.
thomaseizinger
changed the title
thomaseizinger
changed the title
thomaseizinger
approved these changes
Sep 5, 2023
|
Thank you! I queued this into the next milestone. It will likely still be a while until we make another release with breaking changes :) |
|
Thanks @chirag-bgh for your work! |
thomaseizinger
changed the title
|
This pull request has merge conflicts. Could you please resolve them @chirag-bgh? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @chirag-bgh? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4412.
Notes & open questions
Change checklist