Merge branch 'master' into feat/perf-remove-keep-until

libp2p · Oct 16, 2023 · 9d652b9 · 9d652b9
2 parents b77234f + 29c44e8
commit 9d652b9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -229,8 +229,7 @@ jobs:
         with:
           save-if: ${{ github.ref == 'refs/heads/master' }}
 
-      - name: Run cargo clippy
-        run: cargo clippy
+      - run: cargo clippy --all-targets --all-features
 
   ipfs-integration-test:
     name: IPFS Integration tests

diff --git a/protocols/kad/CHANGELOG.md b/protocols/kad/CHANGELOG.md
@@ -8,6 +8,12 @@
 
 [PR 4547]: https://github.com/libp2p/rust-libp2p/pull/4547
 
+<!-- Internal changes:
+
+- Fix lints in tests
+
+-->
+
 ## 0.44.5
 - Migrate to `quick-protobuf-codec` crate for codec logic.
   See [PR 4501].

diff --git a/protocols/kad/src/handler.rs b/protocols/kad/src/handler.rs
@@ -1224,14 +1224,14 @@ mod tests {
 
             match current {
                 None => {
-                    assert_eq!(new.reported, false);
+                    assert!(!new.reported);
                     assert_eq!(new.supported, now_supported);
                 }
                 Some(current) => {
                     if current.supported == now_supported {
-                        assert_eq!(new.reported, true);
+                        assert!(new.reported);
                     } else {
-                        assert_eq!(new.reported, false);
+                        assert!(!new.reported);
                     }
 
                     assert_eq!(new.supported, now_supported);