Apply suggestions from code review

Co-authored-by: Max Inden <[email protected]>
libp2p · Nov 20, 2023 · 14e336e · 14e336e
1 parent d866ca0
commit 14e336e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/libp2p/src/builder/phase/quic.rs b/libp2p/src/builder/phase/quic.rs
@@ -212,7 +212,7 @@ impl<T: AuthenticatedMultiplexedTransport> SwarmBuilder<super::provider::Tokio,
 
 macro_rules! impl_quic_phase_with_websocket {
     ($providerKebabCase:literal, $providerPascalCase:ty, $websocketStream:ty) => {
-        #[cfg(all(feature = $providerKebabCase, not(target_arch = "wasm32"), feature = "websocket", feature = "tcp"))]
+        #[cfg(all(feature = $providerKebabCase, not(target_arch = "wasm32"), feature = "websocket", feature = "tcp", feature = "dns"))]
         impl<T: AuthenticatedMultiplexedTransport> SwarmBuilder<$providerPascalCase, QuicPhase<T>> {
             /// See [`SwarmBuilder::with_websocket`].
             pub async fn with_websocket <

diff --git a/libp2p/src/builder/phase/tcp.rs b/libp2p/src/builder/phase/tcp.rs
@@ -185,7 +185,7 @@ impl<Provider> SwarmBuilder<Provider, TcpPhase> {
 }
 macro_rules! impl_tcp_phase_with_websocket {
     ($providerKebabCase:literal, $providerPascalCase:ty, $websocketStream:ty) => {
-        #[cfg(all(feature = $providerKebabCase, not(target_arch = "wasm32"), feature = "websocket", feature = "tcp"))]
+        #[cfg(all(feature = $providerKebabCase, not(target_arch = "wasm32"), feature = "websocket", feature = "tcp", feature = "dns"))]
         impl SwarmBuilder<$providerPascalCase, TcpPhase> {
             /// See [`SwarmBuilder::with_websocket`].
             pub async fn with_websocket <

diff --git a/libp2p/src/builder/phase/websocket.rs b/libp2p/src/builder/phase/websocket.rs
@@ -215,11 +215,11 @@ impl<Provider, T: AuthenticatedMultiplexedTransport> SwarmBuilder<Provider, Webs
 
 #[derive(Debug, thiserror::Error)]
 #[error(transparent)]
-#[cfg(all(not(target_arch = "wasm32"), feature = "websocket", feature = "tcp"))]
+#[cfg(all(not(target_arch = "wasm32"), feature = "websocket", feature = "tcp", feature = "dns"))]
 pub struct WebsocketError<Sec>(#[from] WebsocketErrorInner<Sec>);
 
 #[derive(Debug, thiserror::Error)]
-#[cfg(all(not(target_arch = "wasm32"), feature = "websocket", feature = "tcp"))]
+#[cfg(all(not(target_arch = "wasm32"), feature = "websocket", feature = "tcp", feature = "dns"))]
 enum WebsocketErrorInner<Sec> {
     #[error("SecurityUpgrade")]
     SecurityUpgrade(Sec),