Update quic-go to v0.49.0 #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small breaking change around Errors.Is for StreamError
MarcoPolo
force-pushed
the
marco/quic-go-v049
branch
from
5f86c11 to
7694b19
Compare
aschmahmann
approved these changes
Jan 24, 2025
| n, err = s.Stream.Read(b) | ||
| if err != nil && errors.Is(err, &quic.StreamError{}) { | ||
| if err != nil && errors.As(err, &streamErr) { |
There was a problem hiding this comment.
I see, this is due to a breaking change in quic-go to make errors.Is be an approximation for an equality check instead of for type checking as it was before. Given the situation LGTM.
There was a problem hiding this comment.
That's correct. We implemented errors.Is incorrectly for the longest time, and now we finally fixed this.
MarcoPolo
added a commit
that referenced
this pull request
Jan 24, 2025
(cherry picked from commit fde0e3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small breaking change around Errors.Is for StreamError