Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Added tests #193

Closed
wants to merge 4 commits into from
Closed

Added tests #193

wants to merge 4 commits into from

Conversation

NickEckardt
Copy link

Wrote some rudimentary tests to ensure examples work. The primary goal here is to provide a way to compile and run all examples and check for compile or runtime errors. Tests for correctness of the examples will still need to be done. For example, the chat-with-rendezvous test passes, however chat-with-rendezvous does not work in its current state.

Also, the libp2p-host test fails since libp2p-host currently suffers from a runtime error. Removing references to quic fixes the problem and the test passes. A better solution would be to get quic working instead of just removing it.

Note: This is my first time writing code with go, please let me know if my code isn't idiomatic or if I'm using the testing framework wrong.

@jacobheun
Copy link
Contributor

@aarshkshah1992 can you take a look at this when you have a chance and help shepherd getting the tests in so we can more reliably update the examples?

@aarshkshah1992 aarshkshah1992 self-assigned this Jan 16, 2021
@aarshkshah1992 aarshkshah1992 self-requested a review January 16, 2021 06:12
@aarshkshah1992
Copy link
Collaborator

@jacobheun Sure.

@airswing
Copy link

@NickEckardt The binary file libp2p-host/libp2p-host shouldn't be committed.

@NickEckardt
Copy link
Author

@eliasmarkc Good catch, fixed.

@aarshkshah1992
Copy link
Collaborator

@NickEckardt Thank you for your PR. The work will be incorporated in a follow-up PR for #195 once we have fixed the examples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants