Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing modifier data related information with lbu_files/nemeth_edit.ctb file #102

Merged

Conversation

hammera
Copy link
Contributor

@hammera hammera commented Dec 8, 2023

Hi guys,

When Norbert and I worked on the modifications to the Nemeth boards, I filled in the standard data related to the modification (name, e-mail address in a distorted form, and the year of the modification when the change was made) according to the usual standard for most of the boards.
Where norbert created a completely new table, I used the Copyright style text, where expansion or modification took place, where I used the expanded and modified by type text, and inserted Norbert's name and email address in distorted form.
Unfortunately, this data was not filled in for the lbu_files/nemeth_edit.ctb table, when Norbert sent a completely new version after the first revision, I forgot filling the proper modification related information line the table before the 13TH line, accidentally uploaded the change to our development branch without the necessary information.
The other tables are fine, I fixed this one line only in the nemeth_edit.ctb file.

Attila

@hammera hammera changed the title Hi guys, When Norbert and I worked on the modifications to the Nemeth boards, I filled in the standard data related to the modification (name, e-mail address in a distorted form, and the year of the modification when the change was made) according to the usual standard for most of the boards. Where norbert created a completely new table, I used the Copyright style text, where expansion or modification took place, where I used the expanded and modified by type text, and inserted Norbert's name and email address in distorted form. Unfortunately, this data was not filled in for the lbu_files/nemeth_edit.ctb table, when Norbert sent a completely new version after the first revision, I forgot filling the proper modification related information line the table before the 13TH line, accidentally uploaded the change to our development branch without the necessary information. The other tables are fine, I fixed this one line only in the nemeth_edit.ctb file. Attila Add missing modifier data related information with lbu_files/nemeth_edit.ctb file Dec 8, 2023
@hammera
Copy link
Contributor Author

hammera commented Dec 8, 2023

Auch, the Viskunde tables related Liblouis master version change results now with Liblouis stable build happens right (the 3.27.0 version, because not migrated yet the version numbers to 3.28.0 version), but master branch five voluve tests are failing.
See pull request #101 with detailed informations.
I trying mark xfail the proper failing test until viskunde tables are not fixed in Liblouisutdml side.

@egli egli merged commit d153472 into liblouis:master Jun 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants