Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Adjust shell complete cargo command to specify package #437

Merged
merged 1 commit into from
Dec 4, 2023
Merged

cli: Adjust shell complete cargo command to specify package #437

merged 1 commit into from
Dec 4, 2023

Conversation

danielocfb
Copy link
Collaborator

The README for blazecli mentions how to build the shell-complete binary, but the command for doing so is relative to the cli/ sub-directory. That's not the case for other commands higher up in the README. Add the necessary package specification to make this command behave as the others.

The README for blazecli mentions how to build the shell-complete binary,
but the command for doing so is relative to the cli/ sub-directory.
That's not the case for other commands higher up in the README.
Add the necessary package specification to make this command behave as
the others.

Signed-off-by: Daniel Müller <[email protected]>
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (935387f) 92.16% compared to head (8350a51) 92.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          41       41           
  Lines        6341     6341           
=======================================
  Hits         5844     5844           
  Misses        497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-e-s-o d-e-s-o merged commit 1534aee into libbpf:main Dec 4, 2023
29 checks passed
@d-e-s-o d-e-s-o deleted the topic/cli-readme branch December 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants