Skip to content

Commit

Permalink
add -lm to DUMB_LIBRARIES
Browse files Browse the repository at this point in the history
Without -lm, cmake finds the include paths and libraries, can compile
the test program, but cannot link it. Then, cmake declares that DUMB is
not installed despite properly installed DUMB headers and libs.

Tested on Arch with the dumb 1.0-1 package. Unsure if this is necessary
on other systems, and unsure whether it flat-out breaks the build on
other systems.
  • Loading branch information
SimonN committed Sep 13, 2017
1 parent 94da476 commit d713245
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/FindDUMB.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ find_package_handle_standard_args(DUMB DEFAULT_MSG
DUMB_INCLUDE_DIR DUMB_LIBRARY)

if(DUMB_FOUND)
set(DUMB_LIBRARIES ${DUMB_LIBRARY})
set(DUMB_LIBRARIES ${DUMB_LIBRARY};m)
else(DUMB_FOUND)
set(DUMB_LIBRARIES)
endif(DUMB_FOUND)
Expand Down

0 comments on commit d713245

Please sign in to comment.