-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RWKV example #24
Add RWKV example #24
Conversation
28717a6
to
e8be370
Compare
I've a complicated relationship with conda these days, so if you want an "Anaconda free" |
@Nintorac what is the difference between chat and complete function in lib_raven.py? |
In the chat code at BlinkDL/RWKV-LM, there is a check where it will stop to generate text after it sees double new line "\n\n", would you also implement it? or will you prefer to check the "Bob:" to stop the generation instead of "\n\n", since there is possibility that the generated text could include "\n\n" without followed by "Bob:" for example if I ask the chat bot to write code, it will generate "\n\n" before any code. |
nothing apparently 😓
No, won't implement that. The OpenAI API has a stop words argument which I had a go at implementing. I had it working locally and was going to upstream to chatrwkv repo but work has picked up so lost that thread for now |
@cahya-wirawan got motivated and finished off the stop words code see here - BlinkDL/ChatRWKV#106 |
@Nintorac have you tried the embedding function and tested if it create similar vector for two similar sentences? |
Have been working towards this but no luck so far. The langchain QA chain uses deprecated openai endpoints and simpleAI does not implement them. Working on batched inference (and generations) at the moment as I thought it would be more widely beneficial and didn't want to have build the vector store one by one |
Yes, I am wondering about following code, why context is created from a list of inputs, but at the end only the first one is used:
|
Closing in favour of https://github.com/Nintorac/simple_rwkv :)
premature optimisation >< Parallel can work now though BlinkDL/ChatRWKV#113 |
I should have been faster reviewing and merging this PR I guess, but won't hold a grudge. Solid work still, gave it its first star :) |
You could still reopen the PR and merge it if you like and @Nintorac agree with it I guess :-) |
Yea, no problem to still merging it I tried to leave it in a good state here. My plans just got bigger! |
No description provided.