Allowing IPv6 addresses in RespondTo and DontRespondTo #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still handles IPv4 addresses as well.
compresses expanded IPv6 addresses
Added IPv6 options to RespondTo and DontRespondTo
removed redundant upper()
added Don't Respond To instructions
Added a IPv6 check for the DNS address. IsOnTheSameSubnet does not currently support IPv6 which is fine as ICMP-Redirecy.py currently does not yet support IPv6 either.
|
Also added a IPv6 check for the DNS address to LLMNR.py . IsOnTheSameSubnet does not currently support IPv6 which is fine as ICMP-Redirect.py currently does not yet support IPv6 either. Should temporarily resolve Issue#152 |
Open
|
Good addition, thanks for submitting this PR. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExpandIpRangesinsettings.pydid not handle IPv6 addresses. Added additional logic that function which:Also updated
Responder.confin include IPv6 examples for theRespondToandDontRespondTooptions as wells as including a note that, for systems with both and IPv4 and IPv6 address, BOTH addresses must be included in theDontRespondTooption in order to be effective.