-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds initial CI pipeline support #13
Conversation
…Windows; adds CI pipeline stage to lint sources; cleans up sources according to recommendations from linter; replaces the lfortran testing script with sinon stubs; adds CI pipeline badges to readme
The CI has the following failure in
But the test "passes". Is that expected? How is LFortran installed at the CI? I can't find the installation process, but the tests seem to use it? |
The error is expected. The tests with errors check how well the server recovers from erroneous output from lfortran. mocha does not swallow stdout or stderr when it runs the tests, so all the logging information gets printed in the tests. lfortran is not installed as part of the unit tests. I need to add an additional suite of integration tests for it and VSCode. The unit tests are intended to assert that our extension behaves as intended with the expected outputs from lfortran and the expected inputs from VSCode. The unit tests should not break if something changes in lfortran or VSCode, but the integration tests should. The integration tests will also be much slower to initialize and run. Edit: I'll work on adding the integration tests for the rest of today. I didn't want this PR to get too big so I went ahead and submitted it. Edit: The call to lfortran is stubbed with sinon in the unit tests. You'll see statements like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge it. See #14 for adding lfortran.
Major changes: