Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install LFortran at the CI #14

Open
certik opened this issue Nov 21, 2024 · 5 comments
Open

Install LFortran at the CI #14

certik opened this issue Nov 21, 2024 · 5 comments

Comments

@certik
Copy link
Contributor

certik commented Nov 21, 2024

The easiest would be to just install LFortran using conda on all platforms.

But I don't know if we can live with the "lag" that we fix some bug / add a new feature and we have to make a release, update conda (so at least several hours iteration). But if we can, the advantage would be that we test the actual conda package that it just works, so we don't have to test it separately, and the CI would test it just like users would install it.

@certik
Copy link
Contributor Author

certik commented Nov 21, 2024

@Pranavchiku currently one must install LFortran with the WITH_LSP=ON cmake flag. Is there any reason not to make this flag on by default (and enable at conda)? Is is slowing something down for regular compilation?

@Pranavchiku
Copy link
Member

@Pranavchiku currently one must install LFortran with the WITH_LSP=ON cmake flag

I don't see any drop in performance. We can do that but it needs refactoring at the following lines. I'll do that.

    if (show_asr || compiler_options.lookup_name) {
#ifdef HAVE_LFORTRAN_RAPIDJSON
        std::cout<<"arg_file: "<<arg_file<<std::endl;
        return get_definitions(arg_file, compiler_options);
#else
        return emit_asr(arg_file, lfortran_pass_manager,
                compiler_options);
#endif
    }

@Pranavchiku
Copy link
Member

Enabled by default at lfortran/lfortran#5438

@certik
Copy link
Contributor Author

certik commented Nov 22, 2024

Here is how we can create a conda package of the latest lfortran: lfortran/lfortran#5451.

@dylon
Copy link
Collaborator

dylon commented Dec 1, 2024

This was added as part of #16, but I will leave the issue open until we can replace the cloned repository with a conda dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants