Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update documentation to describe project setup #20

Closed

Conversation

ModeSevenIndustrialSolutions
Copy link
Contributor

We need to be clear about the steps involved in setting this up for new projects at the LF. Happy to take comments on the additions in this PR.

@@ -78,6 +78,19 @@ Or, submit each commit as a separate single commit preserving the git history (S
- `ORGANIZATION`: The GitHub Organization or Project.
- `REVIEWER_EMAIL`: Committers' email list (comma-separated list without spaces).

## Deploying to a New Linux Foundation Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having another section, please move these steps to pre-requisites (see ln 10+) above, there is already a well-maintained doc on how to create SSH keys and use them.

https://docs.releng.linuxfoundation.org/en/latest/gerrit.html#register-key-gerrit

@@ -78,6 +78,19 @@ Or, submit each commit as a separate single commit preserving the git history (S
- `ORGANIZATION`: The GitHub Organization or Project.
- `REVIEWER_EMAIL`: Committers' email list (comma-separated list without spaces).

## Deploying to a New Linux Foundation Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this generic so that anyone outside of LF can follow the guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should simply be documented on the LF RelEng Confluence Wiki instead? There are concrete steps needed to set this up for LF projects that are NOT for general consumption, which are currently missing. If you want generic documentation, perhaps our internal docs should go elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@askb
Copy link
Contributor

askb commented Oct 18, 2024

The PR tittle should be "Docs: ..." or "Fix: ..." instead of "Feat: ..."

@ModeSevenIndustrialSolutions
Copy link
Contributor Author

auto-merge was automatically disabled October 21, 2024 13:43

Pull request was closed

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions deleted the update-docs branch October 21, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants