Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add focustree quests #136

Merged
merged 9 commits into from
Dec 1, 2023
Merged

feat: add focustree quests #136

merged 9 commits into from
Dec 1, 2023

Conversation

ayushtom
Copy link
Contributor

No description provided.

@ayushtom ayushtom marked this pull request as ready for review November 23, 2023 10:35
@ayushtom ayushtom requested review from irisdv and Th0rgal and removed request for irisdv November 23, 2023 10:35
@ayushtom ayushtom added the 🔥 Ready for review This pull request needs a review label Nov 23, 2023
@ayushtom ayushtom added 🚧 In progress do not merge Pull Request in progress, please do not merge and removed 🔥 Ready for review This pull request needs a review labels Nov 26, 2023
@Th0rgal
Copy link
Member

Th0rgal commented Nov 27, 2023

Hey,

I just had a call with Focus Tree team and they wanted to simplify the quest. Instead of having a task "send your nft to your focus tree wallet", let's just make the "Claim rewards" button open a modal showing a description from the db field "rewards_description" .

That description will tell the user to go to focustree app to receive their gift, and they will do the transfer there.

@Kevils
Copy link

Kevils commented Nov 27, 2023

@ayushtom ayushtom force-pushed the ayush/focustree-quest branch from 2719c12 to ff2d7cd Compare November 27, 2023 20:19
@ayushtom ayushtom added 🔥 Ready for review This pull request needs a review and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Nov 29, 2023
@irisdv irisdv self-requested a review November 30, 2023 14:42
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the "quest" part, I'll let Thomas review the rust part !

State(state): State<Arc<AppState>>,
Query(query): Query<TwitterOAuthCallbackQuery>,
) -> impl IntoResponse {
let quest_id = 124;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why quest_id = 124 ?
I think quest_id should be 21
You can follow the ids in here and update the doc accordingly so we don't get mixed up : https://app.skiff.com/file/99417b27-ffcd-487a-8d1f-affa7019e2af

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

(
"redirect_uri",
&format!(
"{}/quests/avnu/discord_fw_callback",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you need to update the redirect_uri so it matches the uri of your endpoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Thanks!

Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rust part lgtm, thank you Iris

@ayushtom ayushtom requested a review from irisdv November 30, 2023 23:21
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 0bd7a25 into master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants