-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add focustree quests #136
Conversation
Hey, I just had a call with Focus Tree team and they wanted to simplify the quest. Instead of having a task "send your nft to your focus tree wallet", let's just make the "Claim rewards" button open a modal showing a description from the db field "rewards_description" . That description will tell the user to go to focustree app to receive their gift, and they will do the transfer there. |
I'm designing something for popup on this figma file : https://www.figma.com/file/fh0OAvj4AS08kHoSxu3DkE/Starknet-Quest?type=design&node-id=2741%3A5386&mode=design&t=cP6LwFhLLQzwEkGZ-1 |
2719c12
to
ff2d7cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed the "quest" part, I'll let Thomas review the rust part !
State(state): State<Arc<AppState>>, | ||
Query(query): Query<TwitterOAuthCallbackQuery>, | ||
) -> impl IntoResponse { | ||
let quest_id = 124; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why quest_id = 124
?
I think quest_id
should be 21
You can follow the ids in here and update the doc accordingly so we don't get mixed up : https://app.skiff.com/file/99417b27-ffcd-487a-8d1f-affa7019e2af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
( | ||
"redirect_uri", | ||
&format!( | ||
"{}/quests/avnu/discord_fw_callback", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you need to update the redirect_uri
so it matches the uri of your endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rust part lgtm, thank you Iris
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.