-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility issues with Doctrine. #460
base: 6.0
Are you sure you want to change the base?
Conversation
@ouss-oud Could you please also backport the github actions from master? So that unit tests will run here. If they pass, it can be merged. |
@ouss-oud Thank you for your effort. It looks very clever, I don't fully understand it, but I know it is not what I meant. I mean that we have a github action in master that runs the unit tests for each PR. That one was probably introduced after the 6.0 branch was separated and should be backported manually into this PR to make the unit tests run. I hope this is clearer. We should not automatically backport as this will cause issues. |
@bartmcleod I copied .github/workflows/php.yml from master branch |
@ouss-oud Thank you, this is what I meant. I suppose that the composer script is still missing: it will need to be copied manually from composer.json in master. |
Hello @ouss-oud @bartmcleod, do you have any news on this topic ? This compatibility issue is causing quite some troubles. If you need someone to do a new PR I can give it a try. |
@Traineau What needs to be modified / added is the composer script that the action wants to run and possibly a different php version there. The reason is that I will merge anything that looks reasonable and passes the tests, but now these don't run. That said, I could run those locally, but usually I don't have time to go there. |
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: '8.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Traineau this php version might not be right for the target version of Symfony
composer test | ||
- name: Run test suite | ||
run: | | ||
composer test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Traineau the test action needs to be copied from the composer.json in the master branch
@bartmcleod I can take over (#465 ) as there have been no replies to this conversation for a while. |
No description provided.