fix: hightlighting breaks after single line doc #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment instead of only the begin and end captures
Blond11516
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks for the fix!
I would've liked to maintain markdown highlighting within the string but couldn't get that to work without losing comment coloring on the closing " so I'll approve as-is. I might come back and try again later.
I've also put the comment scope back on the whole line. Since markdown highlighting no longer works there's no point treating the separate parts distinctly.
|
Great, thanks for getting to this so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc comments like
@doc "foo"break syntax highlighting after 0.0.19#91
Before
VSCode 1.96.2 and Lexical 0.0.19
Cursor 0.44.11 and Lexical 0.0.19
After
Cursor 0.44.11