Check for an existing data listing before attempting to add one #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of catching an exception
|
I think this resolves #1? |
|
This does fix the issue with the nrf52 SVD file. Thank you @eShuttleworth |
|
So? Merge? :) |
|
Ah, so that's why. Could it be listed as an "overlay" region? Interestingly, with the nrf51 SVD, I still needed to put an exception handler around this, even with the check. |
|
Thanks a lot, will try this PR and merge if successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to apply an SVD to a Nordic nRF52, the loader fails due to conflicting data at some of the peripheral addresses. Turns out that Nordic lists multiple peripherals as having the same base address and (I think) allows one to switch between them based on context or something. In any case, checking for an existing data listing before adding one fixes this.
Resulting listing view: